Add a comment and rename the tokenType for clarity

Author: gonzaloriestra

packages/app/src/cli/utilities/developer-platform-client.test.ts

@@ -67,9 +67,9 @@ describe('createUnauthorizedHandler', () => {
     expect(mockClient.unsafeRefreshToken).toHaveBeenCalledTimes(1)
   })
 
-  test('returns appManagement token when tokenType is appManagement', async () => {
+  test('returns default token when tokenType is default', async () => {
     const mockClient = createMockClient()
-    const handler = createUnauthorizedHandler(mockClient, 'appManagement')
+    const handler = createUnauthorizedHandler(mockClient, 'default')
 
     const result = await handler.handler()
 

packages/app/src/cli/utilities/developer-platform-client.ts

@@ -296,9 +296,18 @@ export interface DeveloperPlatformClient {
 
 const inProgressRefreshes = new WeakMap<DeveloperPlatformClient, Promise<string>>()
 
+/**
+ * Creates an unauthorized handler for a developer platform client that will refresh the token
+ * and return the appropriate token based on the token type.
+ * If the tokenType is 'businessPlatform', the handler will return the business platform token.
+ * Otherwise, it will return the default token (App Management API or Partners API).
+ * @param client - The developer platform client.
+ * @param tokenType - The type of token to return ('default' or 'businessPlatform')
+ * @returns The unauthorized handler.
+ */
 export function createUnauthorizedHandler(
   client: DeveloperPlatformClient,
-  tokenType: 'appManagement' | 'businessPlatform' = 'appManagement',
+  tokenType: 'default' | 'businessPlatform' = 'default',
 ): UnauthorizedHandler {
   return {
     type: 'token_refresh',

packages/app/src/cli/utilities/developer-platform-client/app-management-client.ts

@@ -856,7 +856,7 @@ export class AppManagementClient implements DeveloperPlatformClient {
       token: await this.businessPlatformToken(),
       organizationId: String(numberFromGid(orgId)),
       variables,
-      unauthorizedHandler: this.createUnauthorizedHandler('appManagement'),
+      unauthorizedHandler: this.createUnauthorizedHandler(),
     })
     const provisionResult = fullResult.organizationUserProvisionShopAccess
     if (!provisionResult.success) {
@@ -1057,7 +1057,7 @@ export class AppManagementClient implements DeveloperPlatformClient {
       token: await this.businessPlatformToken(),
       organizationId,
       variables,
-      unauthorizedHandler: this.createUnauthorizedHandler('appManagement'),
+      unauthorizedHandler: this.createUnauthorizedHandler(),
     })
     const result: {[flag: (typeof allBetaFlags)[number]]: boolean} = {}
     allBetaFlags.forEach((flag) => {
@@ -1072,7 +1072,7 @@ export class AppManagementClient implements DeveloperPlatformClient {
     return appManagementRequestDoc({
       ...options,
       token: await this.token(),
-      unauthorizedHandler: this.createUnauthorizedHandler('appManagement'),
+      unauthorizedHandler: this.createUnauthorizedHandler(),
     })
   }
 
@@ -1082,7 +1082,7 @@ export class AppManagementClient implements DeveloperPlatformClient {
     return appDevRequestDoc({
       ...options,
       token: await this.token(),
-      unauthorizedHandler: this.createUnauthorizedHandler('appManagement'),
+      unauthorizedHandler: this.createUnauthorizedHandler(),
     })
   }
 
@@ -1112,7 +1112,7 @@ export class AppManagementClient implements DeveloperPlatformClient {
     return functionsRequestDoc<TResult, TVariables>({
       ...options,
       token: await this.token(),
-      unauthorizedHandler: this.createUnauthorizedHandler('appManagement'),
+      unauthorizedHandler: this.createUnauthorizedHandler(),
     })
   }
 
@@ -1122,13 +1122,11 @@ export class AppManagementClient implements DeveloperPlatformClient {
     return webhooksRequestDoc<TResult, TVariables>({
       ...options,
       token: await this.token(),
-      unauthorizedHandler: this.createUnauthorizedHandler('appManagement'),
+      unauthorizedHandler: this.createUnauthorizedHandler(),
     })
   }
 
-  private createUnauthorizedHandler(
-    tokenType: 'appManagement' | 'businessPlatform' = 'appManagement',
-  ): UnauthorizedHandler {
+  private createUnauthorizedHandler(tokenType: 'default' | 'businessPlatform' = 'default'): UnauthorizedHandler {
     return createUnauthorizedHandler(this, tokenType)
   }
 }