Commit 4430afa
Ensure 'Other' group always appears last with groupOrder
Implement alternative approach where items without groups ('Other') always appear at the very end, regardless of groupOrder specification. This provides better UX as users expect the fallback 'Other' category to be last.
Changes:
- Update SelectInput sorting logic to use MAX_SAFE_INTEGER + 1 for ungrouped items
- Add comprehensive test demonstrating the new behavior
- Update existing test snapshots to reflect the improved ordering
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>1 parent b77f139 commit 4430afa
File tree
3 files changed
+59
-25
lines changed- .changeset
- packages/cli-kit/src/private/node/ui/components
3 files changed
+59
-25
lines changedThis file was deleted.
Lines changed: 52 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
267 | 267 | | |
268 | 268 | | |
269 | 269 | | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
270 | 306 | | |
271 | 307 | | |
272 | 308 | | |
| |||
383 | 419 | | |
384 | 420 | | |
385 | 421 | | |
386 | | - | |
387 | | - | |
388 | | - | |
389 | | - | |
390 | | - | |
391 | | - | |
392 | | - | |
393 | | - | |
394 | | - | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
395 | 429 | | |
| 430 | + | |
| 431 | + | |
396 | 432 | | |
397 | 433 | | |
398 | 434 | | |
| |||
405 | 441 | | |
406 | 442 | | |
407 | 443 | | |
408 | | - | |
409 | | - | |
410 | | - | |
411 | | - | |
| 444 | + | |
| 445 | + | |
412 | 446 | | |
413 | | - | |
414 | | - | |
415 | | - | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
416 | 450 | | |
417 | 451 | | |
| 452 | + | |
| 453 | + | |
418 | 454 | | |
419 | 455 | | |
420 | 456 | | |
| |||
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
164 | 164 | | |
165 | 165 | | |
166 | 166 | | |
167 | | - | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
168 | 174 | | |
169 | 175 | | |
170 | 176 | | |
| |||
0 commit comments