Skip to content

Commit 46aaf4f

Browse files
Merge pull request #6712 from Shopify/fix-npm-version-release
Fix permission and NPM version in release workflow
2 parents 19a6a9d + 3dced8a commit 46aaf4f

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

.github/workflows/release.yml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,10 @@ jobs:
5252
uses: actions/checkout@v4
5353
with:
5454
fetch-depth: 0
55-
- name: Install pnpm
56-
uses: pnpm/action-setup@fe02b34f77f8bc703788d5817da081398fad5dd2 # [email protected]
55+
- name: Setup deps
56+
uses: ./.github/actions/setup-cli-deps
5757
with:
58-
version: ${{ env.PNPM_VERSION }}
59-
run_install: false
58+
node-version: 24.12.0
6059
- name: Force snapshot changeset
6160
run: "mv .changeset/force-snapshot-build.md.ignore .changeset/force-snapshot-build.md"
6261
- name: Create snapshot version
@@ -87,7 +86,7 @@ jobs:
8786
if: ${{ github.event_name == 'push' || (github.event_name == 'workflow_dispatch' && github.event.inputs.tag == '') }}
8887
runs-on: ubuntu-latest
8988
permissions:
90-
contents: read
89+
contents: write
9190
pull-requests: write
9291
id-token: write
9392
steps:
@@ -98,7 +97,7 @@ jobs:
9897
- name: Setup deps
9998
uses: ./.github/actions/setup-cli-deps
10099
with:
101-
node-version: 24.1.0
100+
node-version: 24.12.0
102101
- name: Create Release Pull Request
103102
uses: changesets/action@e9cc34b540dd3ad1b030c57fd97269e8f6ad905a # pin@v1
104103
with:
@@ -128,7 +127,7 @@ jobs:
128127
- name: Setup deps
129128
uses: ./.github/actions/setup-cli-deps
130129
with:
131-
node-version: 24.1.0
130+
node-version: 24.12.0
132131
- name: Release
133132
run: pnpm release ${{ github.event.inputs.tag || 'nightly' }}
134133
env:

0 commit comments

Comments
 (0)