removed changeset and changed record naming

EvilGenius13 · EvilGenius13 · commit 48744b6a14ec · 2025-11-26T10:48:07.000-05:00
diff --git a/.changeset/curvy-bears-raise.md b/.changeset/curvy-bears-raise.md
diff --git a/packages/cli-kit/src/private/node/api.test.ts b/packages/cli-kit/src/private/node/api.test.ts
@@ -416,7 +416,7 @@ describe('retryAwareRequest', () => {
         url: 'https://themes.example.com/api',
         useNetworkLevelRetry: true,
         maxRetryTimeMs: 10000,
-        recordThemeCommandRetries: true,
+        recordCommandRetries: true,
       },
       undefined,
       {
@@ -471,7 +471,7 @@ describe('retryAwareRequest', () => {
         url: 'https://app.example.com/api',
         useNetworkLevelRetry: true,
         maxRetryTimeMs: 10000,
-        recordThemeCommandRetries: false,
+        recordCommandRetries: false,
       },
       undefined,
       {
@@ -528,7 +528,7 @@ describe('retryAwareRequest', () => {
         url: 'https://themes.example.com/upload',
         useNetworkLevelRetry: true,
         maxRetryTimeMs: 10000,
-        recordThemeCommandRetries: true,
+        recordCommandRetries: true,
       },
       undefined,
       {
@@ -584,7 +584,7 @@ describe('retryAwareRequest', () => {
         url: 'https://themes.example.com/auth',
         useNetworkLevelRetry: true,
         maxRetryTimeMs: 10000,
-        recordThemeCommandRetries: true,
+        recordCommandRetries: true,
       },
       undefined,
       {
diff --git a/packages/cli-kit/src/private/node/api.ts b/packages/cli-kit/src/private/node/api.ts
@@ -18,11 +18,11 @@ export type NetworkRetryBehaviour =
   | {
       useNetworkLevelRetry: true
       maxRetryTimeMs: number
-      recordThemeCommandRetries?: boolean
+      recordCommandRetries?: boolean
     }
   | {
       useNetworkLevelRetry: false
-      recordThemeCommandRetries?: boolean
+      recordCommandRetries?: boolean
     }
 
 type RequestOptions<T> = {
@@ -153,8 +153,8 @@ async function runRequestWithNetworkLevelRetry<T extends {headers: Headers; stat
         throw err
       }
 
-      // Record theme command retries
-      if (requestOptions.recordThemeCommandRetries) {
+      // Record command retries
+      if (requestOptions.recordCommandRetries) {
         recordRetry(requestOptions.url, `network-retry:${(err as Error).message}`)
       }
 
@@ -380,8 +380,8 @@ ${result.sanitizedHeaders}
     }
     retriesUsed += 1
 
-    // Record theme command retries
-    if (requestOptions.recordThemeCommandRetries) {
+    // Record command retries
+    if (requestOptions.recordCommandRetries) {
       recordRetry(requestOptions.url, `http-retry-${retriesUsed}:${result.status}:`)
     }
 
diff --git a/packages/cli-kit/src/public/node/themes/api.ts b/packages/cli-kit/src/public/node/themes/api.ts
@@ -37,7 +37,7 @@ const THEME_API_NETWORK_BEHAVIOUR: RequestModeInput = {
   useNetworkLevelRetry: true,
   useAbortSignal: false,
   maxRetryTimeMs: 90 * 1000,
-  recordThemeCommandRetries: true,
+  recordCommandRetries: true,
 }
 
 export async function fetchTheme(id: number, session: AdminSession): Promise<Theme | undefined> {

Original file line number	Diff line number	Diff line change
`@@ -18,11 +18,11 @@ export type NetworkRetryBehaviour =`
`18`	`18`	`\| {`
`19`	`19`	`useNetworkLevelRetry: true`
`20`	`20`	`maxRetryTimeMs: number`
`21`		`- recordThemeCommandRetries?: boolean`
	`21`	`+ recordCommandRetries?: boolean`
`22`	`22`	`}`
`23`	`23`	`\| {`
`24`	`24`	`useNetworkLevelRetry: false`
`25`		`- recordThemeCommandRetries?: boolean`
	`25`	`+ recordCommandRetries?: boolean`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`type RequestOptions<T> = {`
`@@ -153,8 +153,8 @@ async function runRequestWithNetworkLevelRetry<T extends {headers: Headers; stat`
`153`	`153`	`throw err`
`154`	`154`	`}`
`155`	`155`
`156`		`- // Record theme command retries`
`157`		`- if (requestOptions.recordThemeCommandRetries) {`
	`156`	`+ // Record command retries`
	`157`	`+ if (requestOptions.recordCommandRetries) {`
`158`	`158`	recordRetry(requestOptions.url, `network-retry:${(err as Error).message}`)
`159`	`159`	`}`
`160`	`160`
`@@ -380,8 +380,8 @@ ${result.sanitizedHeaders}`
`380`	`380`	`}`
`381`	`381`	`retriesUsed += 1`
`382`	`382`
`383`		`- // Record theme command retries`
`384`		`- if (requestOptions.recordThemeCommandRetries) {`
	`383`	`+ // Record command retries`
	`384`	`+ if (requestOptions.recordCommandRetries) {`
`385`	`385`	recordRetry(requestOptions.url, `http-retry-${retriesUsed}:${result.status}:`)
`386`	`386`	`}`
`387`	`387`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ const THEME_API_NETWORK_BEHAVIOUR: RequestModeInput = {`
`37`	`37`	`useNetworkLevelRetry: true,`
`38`	`38`	`useAbortSignal: false,`
`39`	`39`	`maxRetryTimeMs: 90 * 1000,`
`40`		`- recordThemeCommandRetries: true,`
	`40`	`+ recordCommandRetries: true,`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`export async function fetchTheme(id: number, session: AdminSession): Promise<Theme \| undefined> {`