Merge pull request #5979 from Shopify/skip-auth-for-app-build

Do not require authentication for app build command

Author: gonzaloriestra

packages/app/src/cli/commands/app/app-logs/sources.ts

@@ -1,10 +1,10 @@
 import {appFlags} from '../../../flags.js'
 import {linkedAppContext} from '../../../services/app-context.js'
 import {sources} from '../../../services/app-logs/sources.js'
-import AppCommand, {AppCommandOutput} from '../../../utilities/app-command.js'
+import AppLinkedCommand, {AppLinkedCommandOutput} from '../../../utilities/app-linked-command.js'
 import {globalFlags} from '@shopify/cli-kit/node/cli'
 
-export default class Sources extends AppCommand {
+export default class Sources extends AppLinkedCommand {
   static summary = 'Print out a list of sources that may be used with the logs command.'
 
   static descriptionWithMarkdown = `The output source names can be used with the \`--source\` argument of \`shopify app logs\` to filter log output. Currently only function extensions are supported as sources.`
@@ -16,7 +16,7 @@ export default class Sources extends AppCommand {
     ...appFlags,
   }
 
-  public async run(): Promise<AppCommandOutput> {
+  public async run(): Promise<AppLinkedCommandOutput> {
     const {flags} = await this.parse(Sources)
 
     const {app} = await linkedAppContext({

packages/app/src/cli/commands/app/build.ts

@@ -1,13 +1,13 @@
 import {appFlags} from '../../flags.js'
 import build from '../../services/build.js'
 import {showApiKeyDeprecationWarning} from '../../prompts/deprecation-warnings.js'
-import AppCommand, {AppCommandOutput} from '../../utilities/app-command.js'
-import {linkedAppContext} from '../../services/app-context.js'
+import {localAppContext} from '../../services/app-context.js'
+import AppUnlinkedCommand, {AppUnlinkedCommandOutput} from '../../utilities/app-unlinked-command.js'
 import {Flags} from '@oclif/core'
 import {globalFlags} from '@shopify/cli-kit/node/cli'
 import {addPublicMetadata} from '@shopify/cli-kit/node/metadata'
 
-export default class Build extends AppCommand {
+export default class Build extends AppUnlinkedCommand {
   static summary = 'Build the app, including extensions.'
 
   static descriptionWithMarkdown = `This command executes the build script specified in the element's TOML file. You can specify a custom script in the file. To learn about configuration files in Shopify apps, refer to [App configuration](https://shopify.dev/docs/apps/tools/cli/configuration).
@@ -33,7 +33,7 @@ export default class Build extends AppCommand {
     }),
   }
 
-  async run(): Promise<AppCommandOutput> {
+  async run(): Promise<AppUnlinkedCommandOutput> {
     const {flags} = await this.parse(Build)
     if (flags['api-key']) {
       await showApiKeyDeprecationWarning()
@@ -44,10 +44,8 @@ export default class Build extends AppCommand {
       cmd_app_dependency_installation_skipped: flags['skip-dependencies-installation'],
     }))
 
-    const {app} = await linkedAppContext({
+    const app = await localAppContext({
       directory: flags.path,
-      clientId: apiKey,
-      forceRelink: flags.reset,
       userProvidedConfigName: flags.config,
     })
 

packages/app/src/cli/commands/app/config/link.ts

@@ -1,10 +1,10 @@
 import {appFlags} from '../../../flags.js'
 import {linkedAppContext} from '../../../services/app-context.js'
 import link, {LinkOptions} from '../../../services/app/config/link.js'
-import AppCommand, {AppCommandOutput} from '../../../utilities/app-command.js'
+import AppLinkedCommand, {AppLinkedCommandOutput} from '../../../utilities/app-linked-command.js'
 import {globalFlags} from '@shopify/cli-kit/node/cli'
 
-export default class ConfigLink extends AppCommand {
+export default class ConfigLink extends AppLinkedCommand {
   static summary = 'Fetch your app configuration from the Partner Dashboard.'
 
   static descriptionWithMarkdown = `Pulls app configuration from the Partner Dashboard and creates or overwrites a configuration file. You can create a new app with this command to start with a default configuration file.
@@ -19,7 +19,7 @@ export default class ConfigLink extends AppCommand {
     ...appFlags,
   }
 
-  public async run(): Promise<AppCommandOutput> {
+  public async run(): Promise<AppLinkedCommandOutput> {
     const {flags} = await this.parse(ConfigLink)
 
     const options: LinkOptions = {

packages/app/src/cli/commands/app/config/use.ts

@@ -2,15 +2,15 @@ import {appFlags} from '../../../flags.js'
 import {checkFolderIsValidApp} from '../../../models/app/loader.js'
 import {linkedAppContext} from '../../../services/app-context.js'
 import use from '../../../services/app/config/use.js'
-import AppCommand, {AppCommandOutput} from '../../../utilities/app-command.js'
+import AppLinkedCommand, {AppLinkedCommandOutput} from '../../../utilities/app-linked-command.js'
 import {Args} from '@oclif/core'
 import {globalFlags} from '@shopify/cli-kit/node/cli'
 
 // This is one of the few commands where we don't need a
 // `--config` flag, because we're passing it as an argument.
 const {config, ...appFlagsWithoutConfig} = appFlags
 
-export default class ConfigUse extends AppCommand {
+export default class ConfigUse extends AppLinkedCommand {
   static summary = 'Activate an app configuration.'
 
   static descriptionWithMarkdown = `Sets default configuration when you run app-related CLI commands. If you omit the \`config-name\` parameter, then you'll be prompted to choose from the configuration files in your project.`
@@ -32,7 +32,7 @@ export default class ConfigUse extends AppCommand {
     }),
   }
 
-  public async run(): Promise<AppCommandOutput> {
+  public async run(): Promise<AppLinkedCommandOutput> {
     const {flags, args} = await this.parse(ConfigUse)
 
     await checkFolderIsValidApp(flags.path)

packages/app/src/cli/commands/app/demo/watcher.ts

@@ -1,13 +1,13 @@
 import {appFlags} from '../../../flags.js'
 import {AppEventWatcher, EventType} from '../../../services/dev/app-events/app-event-watcher.js'
-import AppCommand, {AppCommandOutput} from '../../../utilities/app-command.js'
+import AppLinkedCommand, {AppLinkedCommandOutput} from '../../../utilities/app-linked-command.js'
 import {linkedAppContext} from '../../../services/app-context.js'
 import colors from '@shopify/cli-kit/node/colors'
 import {globalFlags} from '@shopify/cli-kit/node/cli'
 import {outputInfo} from '@shopify/cli-kit/node/output'
 import {endHRTimeInMs} from '@shopify/cli-kit/node/hrtime'
 
-export default class DemoWatcher extends AppCommand {
+export default class DemoWatcher extends AppLinkedCommand {
   static summary = 'Watch and prints out changes to an app.'
   static hidden = true
 
@@ -16,7 +16,7 @@ export default class DemoWatcher extends AppCommand {
     ...appFlags,
   }
 
-  public async run(): Promise<AppCommandOutput> {
+  public async run(): Promise<AppLinkedCommandOutput> {
     const {flags} = await this.parse(DemoWatcher)
 
     const {app} = await linkedAppContext({

packages/app/src/cli/commands/app/deploy.ts

@@ -5,13 +5,13 @@ import {validateVersion} from '../../validations/version-name.js'
 import {showApiKeyDeprecationWarning} from '../../prompts/deprecation-warnings.js'
 import {validateMessage} from '../../validations/message.js'
 import metadata from '../../metadata.js'
-import AppCommand, {AppCommandOutput} from '../../utilities/app-command.js'
+import AppLinkedCommand, {AppLinkedCommandOutput} from '../../utilities/app-linked-command.js'
 import {linkedAppContext} from '../../services/app-context.js'
 import {Flags} from '@oclif/core'
 import {globalFlags} from '@shopify/cli-kit/node/cli'
 import {addPublicMetadata} from '@shopify/cli-kit/node/metadata'
 
-export default class Deploy extends AppCommand {
+export default class Deploy extends AppLinkedCommand {
   static summary = 'Deploy your Shopify app.'
 
   static descriptionWithMarkdown = `[Builds the app](https://shopify.dev/docs/api/shopify-cli/app/app-build), then deploys your app configuration and extensions.
@@ -63,7 +63,7 @@ export default class Deploy extends AppCommand {
     }),
   }
 
-  async run(): Promise<AppCommandOutput> {
+  async run(): Promise<AppLinkedCommandOutput> {
     const {flags} = await this.parse(Deploy)
 
     await metadata.addPublicMetadata(() => ({

packages/app/src/cli/commands/app/dev.ts

@@ -2,7 +2,7 @@ import {appFlags} from '../../flags.js'
 import {dev, DevOptions} from '../../services/dev.js'
 import {showApiKeyDeprecationWarning} from '../../prompts/deprecation-warnings.js'
 import {checkFolderIsValidApp} from '../../models/app/loader.js'
-import AppCommand, {AppCommandOutput} from '../../utilities/app-command.js'
+import AppLinkedCommand, {AppLinkedCommandOutput} from '../../utilities/app-linked-command.js'
 import {linkedAppContext} from '../../services/app-context.js'
 import {storeContext} from '../../services/store-context.js'
 import {getTunnelMode} from '../../services/dev/tunnel-mode.js'
@@ -11,7 +11,7 @@ import {normalizeStoreFqdn} from '@shopify/cli-kit/node/context/fqdn'
 import {globalFlags} from '@shopify/cli-kit/node/cli'
 import {addPublicMetadata} from '@shopify/cli-kit/node/metadata'
 
-export default class Dev extends AppCommand {
+export default class Dev extends AppLinkedCommand {
   static summary = 'Run the app.'
 
   static descriptionWithMarkdown = `[Builds the app](https://shopify.dev/docs/api/shopify-cli/app/app-build) and lets you preview it on a [development store](https://shopify.dev/docs/apps/tools/development-stores) or [Plus sandbox store](https://help.shopify.com/partners/dashboard/managing-stores/plus-sandbox-store).
@@ -122,7 +122,7 @@ If you're using the Ruby app template, then you need to complete the following s
     return 'app dev stop'
   }
 
-  public async run(): Promise<AppCommandOutput> {
+  public async run(): Promise<AppLinkedCommandOutput> {
     const {flags} = await this.parse(Dev)
 
     if (!flags['api-key'] && process.env.SHOPIFY_API_KEY) {

packages/app/src/cli/commands/app/dev/clean.ts

@@ -1,13 +1,13 @@
 import {linkedAppContext} from '../../../services/app-context.js'
-import AppCommand, {AppCommandOutput} from '../../../utilities/app-command.js'
+import AppLinkedCommand, {AppLinkedCommandOutput} from '../../../utilities/app-linked-command.js'
 import {appFlags} from '../../../flags.js'
 import {storeContext} from '../../../services/store-context.js'
 import {devClean} from '../../../services/dev-clean.js'
 import {globalFlags} from '@shopify/cli-kit/node/cli'
 import {Flags} from '@oclif/core'
 import {normalizeStoreFqdn} from '@shopify/cli-kit/node/context/fqdn'
 
-export default class DevClean extends AppCommand {
+export default class DevClean extends AppLinkedCommand {
   static summary = 'Cleans up the app preview from the selected store.'
 
   static descriptionWithMarkdown = `Stop the app preview that was started with \`shopify app dev\`.
@@ -31,7 +31,7 @@ export default class DevClean extends AppCommand {
     }),
   }
 
-  public async run(): Promise<AppCommandOutput> {
+  public async run(): Promise<AppLinkedCommandOutput> {
     const {flags} = await this.parse(DevClean)
 
     const appContextResult = await linkedAppContext({

packages/app/src/cli/commands/app/env/pull.ts

@@ -1,14 +1,14 @@
 import {appFlags} from '../../../flags.js'
 import {getDotEnvFileName} from '../../../models/app/loader.js'
 import {pullEnv} from '../../../services/app/env/pull.js'
-import AppCommand, {AppCommandOutput} from '../../../utilities/app-command.js'
+import AppLinkedCommand, {AppLinkedCommandOutput} from '../../../utilities/app-linked-command.js'
 import {linkedAppContext} from '../../../services/app-context.js'
 import {Flags} from '@oclif/core'
 import {globalFlags} from '@shopify/cli-kit/node/cli'
 import {outputResult} from '@shopify/cli-kit/node/output'
 import {joinPath} from '@shopify/cli-kit/node/path'
 
-export default class EnvPull extends AppCommand {
+export default class EnvPull extends AppLinkedCommand {
   static summary = 'Pull app and extensions environment variables.'
 
   static descriptionWithMarkdown = `Creates or updates an \`.env\` files that contains app and app extension environment variables.
@@ -27,7 +27,7 @@ export default class EnvPull extends AppCommand {
     }),
   }
 
-  public async run(): Promise<AppCommandOutput> {
+  public async run(): Promise<AppLinkedCommandOutput> {
     const {flags} = await this.parse(EnvPull)
 
     const {app, remoteApp, organization} = await linkedAppContext({

packages/app/src/cli/commands/app/env/show.ts

@@ -1,11 +1,11 @@
 import {appFlags} from '../../../flags.js'
 import {linkedAppContext} from '../../../services/app-context.js'
 import {showEnv} from '../../../services/app/env/show.js'
-import AppCommand, {AppCommandOutput} from '../../../utilities/app-command.js'
+import AppLinkedCommand, {AppLinkedCommandOutput} from '../../../utilities/app-linked-command.js'
 import {globalFlags} from '@shopify/cli-kit/node/cli'
 import {outputResult} from '@shopify/cli-kit/node/output'
 
-export default class EnvShow extends AppCommand {
+export default class EnvShow extends AppLinkedCommand {
   static summary = 'Display app and extensions environment variables.'
 
   static descriptionWithMarkdown = `Displays environment variables that can be used to deploy apps and app extensions.`
@@ -17,7 +17,7 @@ export default class EnvShow extends AppCommand {
     ...appFlags,
   }
 
-  public async run(): Promise<AppCommandOutput> {
+  public async run(): Promise<AppLinkedCommandOutput> {
     const {flags} = await this.parse(EnvShow)
     const {app, remoteApp, organization} = await linkedAppContext({
       directory: flags.path,