remove deprecated args

Author: EvilGenius13

packages/cli/oclif.manifest.json

@@ -6346,7 +6346,7 @@
       "pluginAlias": "@shopify/cli",
       "pluginName": "@shopify/cli",
       "pluginType": "core",
-      "strict": false,
+      "strict": true,
       "summary": "Set a remote theme as the live theme."
     },
     "theme:pull": {

packages/theme/src/cli/commands/theme/publish.ts

@@ -1,6 +1,6 @@
 import ThemeCommand from '../../utilities/theme-command.js'
 import {themeFlags} from '../../flags.js'
-import {publish, renderArgumentsWarning} from '../../services/publish.js'
+import {publish} from '../../services/publish.js'
 import {Flags} from '@oclif/core'
 import {globalFlags} from '@shopify/cli-kit/node/cli'
 import {OutputFlags} from '@oclif/core/interfaces'
@@ -21,9 +21,6 @@ If you want to publish your local theme, then you need to run \`shopify theme pu
 
   static description = this.descriptionWithoutMarkdown()
 
-  // Accept any number of args without naming them
-  static strict = false
-
   static flags = {
     ...globalFlags,
     ...themeFlags,
@@ -41,16 +38,7 @@ If you want to publish your local theme, then you need to run \`shopify theme pu
 
   static multiEnvironmentsFlags = ['store', 'password', 'theme']
 
-  async command(flags: PublishFlags, adminSession: AdminSession) {
-    // Deprecated use of passing the theme id as an argument
-    // ex: `shopify theme publish <themeid>`
-    const positionalArgValue =
-      this.argv && this.argv.length > 0 && typeof this.argv[0] === 'string' ? this.argv[0] : undefined
-
-    if (!flags.theme && positionalArgValue) {
-      flags.theme = positionalArgValue
-      renderArgumentsWarning(positionalArgValue)
-    }
-    await publish(adminSession, flags)
+  async command(flags: PublishFlags, adminSession: AdminSession, multiEnvironment?: boolean) {
+    await publish(adminSession, flags, multiEnvironment)
   }
 }

packages/theme/src/cli/services/publish.ts

@@ -3,27 +3,16 @@ import {themeComponent} from '../utilities/theme-ui.js'
 import {themePublish} from '@shopify/cli-kit/node/themes/api'
 import {themePreviewUrl} from '@shopify/cli-kit/node/themes/urls'
 import {Theme} from '@shopify/cli-kit/node/themes/types'
-import {renderConfirmationPrompt, renderSuccess, renderWarning} from '@shopify/cli-kit/node/ui'
+import {renderConfirmationPrompt, renderSuccess} from '@shopify/cli-kit/node/ui'
 import {AdminSession} from '@shopify/cli-kit/node/session'
 
-export function renderArgumentsWarning(id: string) {
-  renderWarning({
-    body: [
-      'The theme ID positional argument is deprecated. Use the',
-      {command: '--theme'},
-      'flag instead:\n\n',
-      {command: `$ shopify theme publish --theme ${id}`},
-      {char: '.'},
-    ],
-  })
-}
-
 interface PublishServiceOptions {
   theme: string | undefined
   force: boolean
+  environment?: string
 }
 
-export async function publish(adminSession: AdminSession, options: PublishServiceOptions) {
+export async function publish(adminSession: AdminSession, options: PublishServiceOptions, multiEnvironment?: boolean) {
   const themeToPublish = await findOrSelectTheme(adminSession, {
     header: 'Select a theme to publish',
     filter: {
@@ -35,7 +24,7 @@ export async function publish(adminSession: AdminSession, options: PublishServic
 
   const previewUrl = themePreviewUrl({...themeToPublish, role: 'live'} as Theme, adminSession)
 
-  if (!options.force) {
+  if (!options.force && !multiEnvironment) {
     const accept = await renderConfirmationPrompt({
       message: `Do you want to make '${themeToPublish.name}' the new live theme on ${adminSession.storeFqdn}?`,
       confirmationMessage: `Yes, make '${themeToPublish.name}' the new live theme`,
@@ -47,6 +36,7 @@ export async function publish(adminSession: AdminSession, options: PublishServic
   await themePublish(themeToPublish.id, adminSession)
 
   renderSuccess({
+    headline: options.environment ? `Environment: ${options.environment}` : undefined,
     body: [
       'The theme',
       ...themeComponent(themeToPublish),