Skip to content

Commit 5969f8c

Browse files
authored
Merge pull request #6002 from chrisberthe/add/listings-to-package
Add /listings folder to theme package command
2 parents 41ec03f + 9b52391 commit 5969f8c

File tree

8 files changed

+19
-3
lines changed

8 files changed

+19
-3
lines changed

.changeset/heavy-lies-itch.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@shopify/theme': patch
3+
---
4+
5+
Add /listings folder to theme package command

docs-shopify.dev/commands/theme-package.doc.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ const data: ReferenceEntityTemplateSchema = {
77
88
Only folders that match the [default Shopify theme folder structure](/docs/storefronts/themes/tools/cli#directory-structure) are included in the package.
99
10+
The package includes the \`listings\` directory if present (required for multi-preset themes per [Theme Store requirements](/docs/storefronts/themes/store/requirements#adding-presets-to-your-theme-zip-submission)).
11+
1012
The ZIP file uses the name \`theme_name-theme_version.zip\`, based on parameters in your [settings_schema.json](/docs/storefronts/themes/architecture/config/settings-schema-json) file.`,
1113
overviewPreviewDescription: `Package your theme into a .zip file, ready to upload to the Online Store.`,
1214
type: 'command',

docs-shopify.dev/generated/generated_docs_data.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5831,7 +5831,7 @@
58315831
},
58325832
{
58335833
"name": "theme package",
5834-
"description": "Packages your local theme files into a ZIP file that can be uploaded to Shopify.\n\n Only folders that match the [default Shopify theme folder structure](/docs/storefronts/themes/tools/cli#directory-structure) are included in the package.\n\n The ZIP file uses the name `theme_name-theme_version.zip`, based on parameters in your [settings_schema.json](/docs/storefronts/themes/architecture/config/settings-schema-json) file.",
5834+
"description": "Packages your local theme files into a ZIP file that can be uploaded to Shopify.\n\n Only folders that match the [default Shopify theme folder structure](/docs/storefronts/themes/tools/cli#directory-structure) are included in the package.\n\n The package includes the `listings` directory if present (required for multi-preset themes per [Theme Store requirements](/docs/storefronts/themes/store/requirements#adding-presets-to-your-theme-zip-submission)).\n\n The ZIP file uses the name `theme_name-theme_version.zip`, based on parameters in your [settings_schema.json](/docs/storefronts/themes/architecture/config/settings-schema-json) file.",
58355835
"overviewPreviewDescription": "Package your theme into a .zip file, ready to upload to the Online Store.",
58365836
"type": "command",
58375837
"isVisualComponent": false,

packages/cli/README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2112,6 +2112,10 @@ DESCRIPTION
21122112
Only folders that match the "default Shopify theme folder structure"
21132113
(https://shopify.dev/docs/storefronts/themes/tools/cli#directory-structure) are included in the package.
21142114
2115+
The package includes the `listings` directory if present (required for multi-preset themes per "Theme Store
2116+
requirements"
2117+
(https://shopify.dev/docs/storefronts/themes/store/requirements#adding-presets-to-your-theme-zip-submission)).
2118+
21152119
The ZIP file uses the name `theme_name-theme_version.zip`, based on parameters in your "settings_schema.json"
21162120
(https://shopify.dev/docs/storefronts/themes/architecture/config/settings-schema-json) file.
21172121
```

packages/cli/oclif.manifest.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5863,8 +5863,8 @@
58635863
"args": {
58645864
},
58655865
"customPluginName": "@shopify/theme",
5866-
"description": "Packages your local theme files into a ZIP file that can be uploaded to Shopify.\n\n Only folders that match the \"default Shopify theme folder structure\" (https://shopify.dev/docs/storefronts/themes/tools/cli#directory-structure) are included in the package.\n\n The ZIP file uses the name `theme_name-theme_version.zip`, based on parameters in your \"settings_schema.json\" (https://shopify.dev/docs/storefronts/themes/architecture/config/settings-schema-json) file.",
5867-
"descriptionWithMarkdown": "Packages your local theme files into a ZIP file that can be uploaded to Shopify.\n\n Only folders that match the [default Shopify theme folder structure](https://shopify.dev/docs/storefronts/themes/tools/cli#directory-structure) are included in the package.\n\n The ZIP file uses the name `theme_name-theme_version.zip`, based on parameters in your [settings_schema.json](https://shopify.dev/docs/storefronts/themes/architecture/config/settings-schema-json) file.",
5866+
"description": "Packages your local theme files into a ZIP file that can be uploaded to Shopify.\n\n Only folders that match the \"default Shopify theme folder structure\" (https://shopify.dev/docs/storefronts/themes/tools/cli#directory-structure) are included in the package.\n\n The package includes the `listings` directory if present (required for multi-preset themes per \"Theme Store requirements\" (https://shopify.dev/docs/storefronts/themes/store/requirements#adding-presets-to-your-theme-zip-submission)).\n\n The ZIP file uses the name `theme_name-theme_version.zip`, based on parameters in your \"settings_schema.json\" (https://shopify.dev/docs/storefronts/themes/architecture/config/settings-schema-json) file.",
5867+
"descriptionWithMarkdown": "Packages your local theme files into a ZIP file that can be uploaded to Shopify.\n\n Only folders that match the [default Shopify theme folder structure](https://shopify.dev/docs/storefronts/themes/tools/cli#directory-structure) are included in the package.\n\n The package includes the `listings` directory if present (required for multi-preset themes per [Theme Store requirements](https://shopify.dev/docs/storefronts/themes/store/requirements#adding-presets-to-your-theme-zip-submission)).\n\n The ZIP file uses the name `theme_name-theme_version.zip`, based on parameters in your [settings_schema.json](https://shopify.dev/docs/storefronts/themes/architecture/config/settings-schema-json) file.",
58685868
"flags": {
58695869
"no-color": {
58705870
"allowNo": false,

packages/theme/src/cli/commands/theme/package.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ export default class Package extends ThemeCommand {
1010
1111
Only folders that match the [default Shopify theme folder structure](https://shopify.dev/docs/storefronts/themes/tools/cli#directory-structure) are included in the package.
1212
13+
The package includes the \`listings\` directory if present (required for multi-preset themes per [Theme Store requirements](https://shopify.dev/docs/storefronts/themes/store/requirements#adding-presets-to-your-theme-zip-submission)).
14+
1315
The ZIP file uses the name \`theme_name-theme_version.zip\`, based on parameters in your [settings_schema.json](https://shopify.dev/docs/storefronts/themes/architecture/config/settings-schema-json) file.`
1416

1517
static description = this.descriptionWithoutMarkdown()

packages/theme/src/cli/services/package.test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ describe('packageTheme', () => {
1818
'assets/base.css',
1919
'layout/theme.liquid',
2020
'config/settings_schema.json',
21+
'listings/canine-gourmand/sections/header-group.json',
22+
'listings/dawn/templates/index.json',
2123
'release-notes.md',
2224
'update_extension.json',
2325
]

packages/theme/src/cli/services/package.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ const themeFilesPattern = [
1010
'blocks/**',
1111
'config/**',
1212
'layout/**',
13+
'listings/**/*',
1314
'locales/**',
1415
'sections/**',
1516
'snippets/**',

0 commit comments

Comments
 (0)