Fix other places

Author: gonzaloriestra

packages/app/src/cli/models/extensions/extension-instance.ts

@@ -281,7 +281,7 @@ export class ExtensionInstance<TConfiguration extends BaseConfigType = BaseConfi
   // Functions specific properties
   get buildCommand() {
     const config = this.configuration as unknown as FunctionConfigType
-    return config.build.command
+    return config.build?.command
   }
 
   // Paths to be watched in a dev session

packages/app/src/cli/services/build/extension.test.ts

@@ -215,4 +215,83 @@ describe('buildFunctionExtension', () => {
     ).rejects.toThrow(AbortError)
     expect(releaseLock).not.toHaveBeenCalled()
   })
+
+  test('handles function with undefined build config', async () => {
+    // Given
+    const configWithoutBuild = {
+      name: 'MyFunction',
+      type: 'product_discounts',
+      description: '',
+      configuration_ui: true,
+      api_version: '2022-07',
+      metafields: [],
+    } as unknown as FunctionConfigType
+
+    extension = await testFunctionExtension({config: configWithoutBuild, entryPath: 'src/index.js'})
+    vi.mocked(fileExistsSync).mockResolvedValue(true)
+
+    // When
+    await expect(
+      buildFunctionExtension(extension, {
+        stdout,
+        stderr,
+        signal,
+        app,
+        environment: 'production',
+      }),
+    ).resolves.toBeUndefined()
+
+    // Then
+    expect(buildJSFunction).toHaveBeenCalledWith(extension, {
+      stdout,
+      stderr,
+      signal,
+      app,
+      environment: 'production',
+    })
+    expect(releaseLock).toHaveBeenCalled()
+    // wasm_opt should not be called when build config is undefined
+    expect(runWasmOpt).not.toHaveBeenCalled()
+  })
+
+  test('handles function with build config but undefined path', async () => {
+    // Given
+    const configWithoutPath = {
+      name: 'MyFunction',
+      type: 'product_discounts',
+      description: '',
+      build: {
+        command: 'make build',
+        wasm_opt: true,
+        // path is undefined
+      },
+      configuration_ui: true,
+      api_version: '2022-07',
+      metafields: [],
+    } as unknown as FunctionConfigType
+
+    extension = await testFunctionExtension({config: configWithoutPath})
+    vi.mocked(fileExistsSync).mockResolvedValue(true)
+
+    // When
+    await expect(
+      buildFunctionExtension(extension, {
+        stdout,
+        stderr,
+        signal,
+        app,
+        environment: 'production',
+      }),
+    ).resolves.toBeUndefined()
+
+    // Then
+    expect(exec).toHaveBeenCalledWith('make', ['build'], {
+      stdout,
+      stderr,
+      cwd: extension.directory,
+      signal,
+    })
+    expect(releaseLock).toHaveBeenCalled()
+    expect(runWasmOpt).toHaveBeenCalled()
+  })
 })

packages/app/src/cli/services/build/extension.ts

@@ -151,7 +151,7 @@ export async function buildFunctionExtension(
   try {
     const bundlePath = extension.outputPath
     const relativeBuildPath =
-      (extension as ExtensionInstance<FunctionConfigType>).configuration.build.path ?? joinPath('dist', 'index.wasm')
+      (extension as ExtensionInstance<FunctionConfigType>).configuration.build?.path ?? joinPath('dist', 'index.wasm')
 
     extension.outputPath = joinPath(extension.directory, relativeBuildPath)
 
@@ -161,7 +161,7 @@ export async function buildFunctionExtension(
       await buildOtherFunction(extension, options)
     }
 
-    const wasmOpt = (extension as ExtensionInstance<FunctionConfigType>).configuration.build.wasm_opt
+    const wasmOpt = (extension as ExtensionInstance<FunctionConfigType>).configuration.build?.wasm_opt
     if (fileExistsSync(extension.outputPath) && wasmOpt) {
       await runWasmOpt(extension.outputPath)
     }