Improve error messaging for failures on bulk operation creation

Author: nickwesselman

packages/app/src/cli/services/bulk-operations/execute-bulk-operation.test.ts

@@ -204,9 +204,13 @@ describe('executeBulkOperation', () => {
       query,
     })
 
-    expect(renderWarning).toHaveBeenCalledWith({
-      headline: 'Bulk operation errors.',
-      body: 'query: Invalid query syntax\nunknown: Another error',
+    expect(renderError).toHaveBeenCalledWith({
+      headline: 'Error creating bulk operation.',
+      body: {
+        list: {
+          items: ['query: Invalid query syntax', 'Another error'],
+        },
+      },
     })
 
     expect(renderSuccess).not.toHaveBeenCalled()

packages/app/src/cli/services/bulk-operations/execute-bulk-operation.ts

@@ -74,15 +74,17 @@ export async function executeBulkOperation(input: ExecuteBulkOperationInput): Pr
     : await runBulkOperationQuery({adminSession, query, version})
 
   if (bulkOperationResponse?.userErrors?.length) {
-    const errorMessages = bulkOperationResponse.userErrors
-      .map(
-        (error: {field?: string[] | null; message: string}) =>
-          `${error.field?.join('.') ?? 'unknown'}: ${error.message}`,
-      )
-      .join('\n')
-    renderWarning({
-      headline: 'Bulk operation errors.',
-      body: errorMessages,
+    const errorMessages = bulkOperationResponse.userErrors.map(
+      (error: {field?: string[] | null; message: string}) =>
+        `${error.field ? `${error.field.join('.')}: ` : ''}${error.message}`,
+    )
+    renderError({
+      headline: 'Error creating bulk operation.',
+      body: {
+        list: {
+          items: errorMessages,
+        },
+      },
     })
     return
   }