Commit 718c173
committed
Fix images not loading in theme app extensions
Our wrapper around fs's `readFile` sets a default of `{encoding:
'utf8'}` to the options. This will cause any binary files (like images
or fonts) to not be read properly.
There isn't a way to disable the encoding based on how the function is
currently typed so I'm switching to fs's version of `readFile` which
will handle all file types correctly automatically.1 parent 8cd585f commit 718c173
File tree
2 files changed
+7
-1
lines changed- .changeset
- packages/cli-kit/src/public/node
2 files changed
+7
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| |||
0 commit comments