Merge pull request #5351 from Shopify/shauns/02-04-streamline_dev_check

Streamline dev check

Author: shauns

configurations/tsconfig.json

@@ -20,6 +20,7 @@
       "jsx": "react",
       "paths": {
         "@shopify/cli-kit/*": ["../packages/cli-kit/src/public/*"],
+        "@shopify/theme/*": ["../packages/theme/src/*"],
         "@shopify/cli-kit/typing/*": ["../packages/cli-kit/src/typing/*"],
       },
       "types": [

configurations/vite.config.ts

@@ -67,5 +67,12 @@ export const aliases = (packagePath: string) => {
       },
     },
     {find: '@shopify/cli-kit', replacement: path.join(packagePath, '../cli-kit/src/index')},
+    {
+      find: /@shopify\/theme\/(.+)/,
+      replacement: (importedModule: string) => {
+        return path.join(packagePath, `../theme/src/${importedModule.replace('@shopify/theme/', '')}`)
+      },
+    },
+    {find: '@shopify/theme', replacement: path.join(packagePath, '../theme/src/index')},
   ]
 }

dev.yml

@@ -1,4 +1,4 @@
-name: shopify-cli-next
+name: cli
 
 up:
   - node:
@@ -60,7 +60,5 @@ commands:
     run: bin/spin
 
 check:
-  build: pnpm build
   type-check: pnpm nx affected --target=type-check
   lint: pnpm nx affected --target=lint
-  unit-tests: pnpm nx affected --target=test --exclude=features

nx.json

@@ -56,7 +56,9 @@
           "graphql-codegen:generate:partners",
           "graphql-codegen:generate:webhooks",
           "graphql-codegen:postfix",
-          "graphql-codegen:formatting"
+          "graphql-codegen:formatting",
+          "type-check",
+          "lint"
         ],
         "runtimeCacheInputs": [
           "node bin/cache-inputs.js || node ../../bin/cache-inputs.js || node ../bin/cache-inputs.js"

packages/app/project.json

@@ -38,7 +38,6 @@
     },
     "test": {
       "executor": "nx:run-commands",
-      "dependsOn": ["^build"],
       "options": {
         "command": "pnpm vitest run",
         "cwd": "packages/app"

packages/app/tsconfig.build.json

@@ -2,6 +2,7 @@
     "extends": "./tsconfig.json",
     "exclude": ["**/*.test.ts"],
     "references": [
-      {"path": "../cli-kit"}
+      {"path": "../cli-kit"},
+      {"path": "../theme"}
     ]
 }

packages/app/tsconfig.json

@@ -8,5 +8,5 @@
     "rootDir": "src",
     "tsBuildInfoFile": "dist/tsconfig.tsbuildinfo"
   },
-  "references": [{"path": "../cli-kit"}]
+  "references": [{"path": "../cli-kit"}, {"path": "../theme"}]
 }