Delete the env file after migration

Author: isaacroldan

packages/app/src/cli/models/app/identifiers.ts

@@ -82,10 +82,11 @@ export async function updateAppIdentifiers(
     const envFileContent = dotEnvFileExists ? await readFile(dotenvFile.path) : ''
     const updatedEnvFileContent = patchEnvFile(envFileContent, updatedVariables)
     await writeFile(dotenvFile.path, updatedEnvFileContent)
+
+    // eslint-disable-next-line require-atomic-updates
+    app.dotenv = dotenvFile
   }
 
-  // eslint-disable-next-line require-atomic-updates
-  app.dotenv = dotenvFile
   return app
 }
 

packages/app/src/cli/services/deploy.ts

@@ -12,7 +12,7 @@ import {reloadApp} from '../models/app/loader.js'
 import {ExtensionRegistration} from '../api/graphql/all_app_extension_registrations.js'
 import {getTomls} from '../utilities/app/config/getTomls.js'
 import {renderInfo, renderSuccess, renderTasks, renderConfirmationPrompt, isTTY} from '@shopify/cli-kit/node/ui'
-import {mkdir} from '@shopify/cli-kit/node/fs'
+import {fileExistsSync, mkdir, removeFile} from '@shopify/cli-kit/node/fs'
 import {joinPath, dirname} from '@shopify/cli-kit/node/path'
 import {outputNewline, outputInfo, formatPackageManagerCommand} from '@shopify/cli-kit/node/output'
 import {getArrayRejectingUndefined} from '@shopify/cli-kit/common/array'
@@ -265,6 +265,9 @@ export async function deploy(options: DeployOptions) {
 
     await renderTasks(tasks)
 
+    // Delete the .env file after the first successful deploy to the Dev Dashboard
+    if (didMigrateExtensionsToDevDash && uploadExtensionsBundleResult.versionTag) await deleteEnvFile(app)
+
     await outputCompletionMessage({
       app,
       release,
@@ -285,6 +288,10 @@ export async function deploy(options: DeployOptions) {
   return {app}
 }
 
+async function deleteEnvFile(app: AppLinkedInterface) {
+  if (app.dotenv && fileExistsSync(app.dotenv.path)) await removeFile(app.dotenv.path)
+}
+
 async function outputCompletionMessage({
   app,
   release,