Remove code to delete the tsconfig for ui extensions

We will always want a tsconfig so we can type the shopify global

Author: vividviolet

packages/app/src/cli/services/generate/extension.ts

@@ -244,8 +244,6 @@ async function uiExtensionInit({
 
         if (templateLanguage === 'javascript') {
           await changeIndexFileExtension(directory, srcFileExtension)
-          // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-          await removeUnwantedTemplateFilesPerFlavor(directory, extensionFlavor!.value)
         }
       },
     },
@@ -325,19 +323,6 @@ async function changeIndexFileExtension(extensionDirectory: string, fileExtensio
   await Promise.all(srcFileExensionsToChange)
 }
 
-async function removeUnwantedTemplateFilesPerFlavor(extensionDirectory: string, extensionFlavor: ExtensionFlavorValue) {
-  // Preact needs the tsconfig.json to set the `"jsxImportSource": "preact"` so it can properly build
-  if (extensionFlavor === 'preact') {
-    return
-  }
-
-  // tsconfig.json file is only needed in extension folder to inform the IDE
-  // About the `react-jsx` tsconfig option, so IDE don't complain about missing react import
-  if (extensionFlavor !== 'typescript-react') {
-    await removeFile(joinPath(extensionDirectory, 'tsconfig.json'))
-  }
-}
-
 async function addResolutionOrOverrideIfNeeded(directory: string, extensionFlavor: ExtensionFlavorValue | undefined) {
   if (extensionFlavor === 'typescript-react') {
     await addResolutionOrOverride(directory, {'@types/react': versions.reactTypes})