Apply suggestions from code review

Author: gonzaloriestra

packages/app/src/cli/services/context.test.ts

@@ -576,7 +576,7 @@ describe('ensureDeployContext', () => {
     unsetAppConfigValueSpy.mockRestore()
   })
 
-  test('sets didMigrateExtensionsToDevDash to true when app modules are missing registration UUIDs', async () => {
+  test('sets didMigrateExtensionsToDevDash to true when app modules are missing registration IDs', async () => {
     // Given
     const app = testAppWithConfig({config: {client_id: APP2.apiKey}})
     const identifiers = {
@@ -622,7 +622,7 @@ describe('ensureDeployContext', () => {
     expect(result.didMigrateExtensionsToDevDash).toBe(true)
   })
 
-  test('sets didMigrateExtensionsToDevDash to false when all app modules have registration UUIDs', async () => {
+  test('sets didMigrateExtensionsToDevDash to false when all app modules have registration IDs', async () => {
     // Given
     const app = testAppWithConfig({config: {client_id: APP2.apiKey}})
     const identifiers = {

packages/app/src/cli/services/context.ts

@@ -168,8 +168,7 @@ export async function ensureDeployContext(options: DeployOptions): Promise<Ensur
   // if the current active app version is missing user_identifiers in some app module, then we are migrating to dev dash
   let didMigrateExtensionsToDevDash = false
   if (developerPlatformClient.supportsAtomicDeployments && activeAppVersion) {
-    const missingUids = activeAppVersion.appModuleVersions.some((version) => !version.registrationId)
-    didMigrateExtensionsToDevDash = missingUids
+    didMigrateExtensionsToDevDash = activeAppVersion.appModuleVersions.some((version) => !version.registrationId)
   }
 
   return {identifiers, didMigrateExtensionsToDevDash}