Remove deprecated positional arguments from theme delete command

Previously, `theme delete` command could accept theme
as a positional argument. This behaviour has been
deprecated since the transition to flags three years
ago. The use of positional arguments and the deprecation
warning are now being removed.

Author: dejmedus

.changeset/early-cobras-worry.md

@@ -0,0 +1,5 @@
+---
+'@shopify/theme': minor
+---
+
+Remove deprecated positional arguments from theme delete command

packages/theme/src/cli/commands/theme/delete.ts

@@ -1,7 +1,7 @@
 import {ensureThemeStore} from '../../utilities/theme-store.js'
 import ThemeCommand from '../../utilities/theme-command.js'
 import {themeFlags} from '../../flags.js'
-import {themesDelete, renderDeprecatedArgsWarning} from '../../services/delete.js'
+import {themesDelete} from '../../services/delete.js'
 import {Flags} from '@oclif/core'
 import {globalFlags} from '@shopify/cli-kit/node/cli'
 import {ensureAuthenticatedThemes} from '@shopify/cli-kit/node/session'
@@ -17,9 +17,6 @@ export default class Delete extends ThemeCommand {
 
   static description = this.descriptionWithoutMarkdown()
 
-  // Accept any number of args without naming them
-  static strict = false
-
   static flags = {
     ...globalFlags,
     ...themeFlags,
@@ -47,18 +44,13 @@ export default class Delete extends ThemeCommand {
   }
 
   async run(): Promise<void> {
-    const {flags, argv} = await this.parse(Delete)
+    const {flags} = await this.parse(Delete)
     const {development, force, password, theme} = flags
-    const themes = [...argv, ...(theme ?? [])]
+    const themes = [...(theme ?? [])]
 
     const store = ensureThemeStore(flags)
     const adminSession = await ensureAuthenticatedThemes(store, password)
 
-    const hasDeprecatedArgs = argv.length > 0
-    if (hasDeprecatedArgs) {
-      renderDeprecatedArgsWarning(argv)
-    }
-
     await themesDelete(adminSession, {
       selectTheme: flags['show-all'],
       development,

packages/theme/src/cli/services/delete.test.ts

@@ -1,9 +1,9 @@
-import {themesDelete, renderDeprecatedArgsWarning} from './delete.js'
+import {themesDelete} from './delete.js'
 import {findOrSelectTheme, findThemes} from '../utilities/theme-selector.js'
 import {themeDelete} from '@shopify/cli-kit/node/themes/api'
 import {Theme} from '@shopify/cli-kit/node/themes/types'
 import {test, describe, expect, vi} from 'vitest'
-import {renderConfirmationPrompt, renderSuccess, renderWarning} from '@shopify/cli-kit/node/ui'
+import {renderConfirmationPrompt, renderSuccess} from '@shopify/cli-kit/node/ui'
 
 vi.mock('@shopify/cli-kit/node/ui')
 vi.mock('@shopify/cli-kit/node/themes/api')
@@ -142,21 +142,3 @@ describe('themesDelete', () => {
     expect(renderSuccess).not.toBeCalled()
   })
 })
-
-describe('renderDeprecatedArgsWarning', () => {
-  test('renders the the deprecated-args warning message', async () => {
-    // Given/When
-    renderDeprecatedArgsWarning(['1', '2'])
-
-    // Then
-    expect(renderWarning).toBeCalledWith({
-      body: [
-        'Positional arguments are deprecated. Use the',
-        {command: '--theme'},
-        'flag instead:\n\n',
-        {command: `$ shopify theme delete --theme 1 2`},
-        {char: '.'},
-      ],
-    })
-  })
-})

packages/theme/src/cli/services/delete.ts

@@ -8,7 +8,6 @@ import {
   renderConfirmationPrompt,
   RenderConfirmationPromptOptions,
   renderSuccess,
-  renderWarning,
   InlineToken,
   LinkToken,
 } from '@shopify/cli-kit/node/ui'
@@ -88,17 +87,3 @@ async function isConfirmed(themes: Theme[], store: string) {
 
   return renderConfirmationPrompt(options)
 }
-
-export function renderDeprecatedArgsWarning(argv: string[]) {
-  const ids = argv.join(' ')
-
-  renderWarning({
-    body: [
-      'Positional arguments are deprecated. Use the',
-      {command: '--theme'},
-      'flag instead:\n\n',
-      {command: `$ shopify theme delete --theme ${ids}`},
-      {char: '.'},
-    ],
-  })
-}