Merge pull request #5231 from Shopify/01-17-rethrow_functions_esbuild_errors

Rethrow functions esbuild errors

Author: isaacroldan

packages/app/src/cli/services/build/extension.ts

@@ -186,9 +186,16 @@ export async function buildFunctionExtension(
       await touchFile(bundlePath)
       await writeFile(bundlePath, base64Contents)
     }
-  } catch (error) {
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  } catch (error: any) {
+    // We capture and rethrow as AbortError to avoid random user-code errors being reported as CLI bugs.
+    // At the same time, we need to keep the ESBuild details for the logs. (the `errors` array)
     const errorMessage = (error as Error).message ?? 'Unknown error occurred'
-    throw new AbortError('Failed to build function.', errorMessage)
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    const newError: any = new AbortError('Failed to build function.', errorMessage)
+    // Inject ESBuild errors if present
+    newError.errors = error.errors
+    throw newError
   } finally {
     await releaseLock()
   }