* use extension handle in extension messages

* update app proxy messaging
* add tests for app proxy messaging

Author: nickwesselman

packages/app/src/cli/models/extensions/specifications/app_config_app_proxy.test.ts

@@ -1,4 +1,4 @@
-import spec from './app_config_app_proxy.js'
+import spec, {type AppProxyConfigType} from './app_config_app_proxy.js'
 import {placeholderAppConfiguration} from '../../app/app.test-data.js'
 import {describe, expect, test} from 'vitest'
 
@@ -50,4 +50,37 @@ describe('app_config_app_proxy', () => {
       })
     })
   })
+
+  describe('getDevSessionUpdateMessages', () => {
+    test('should return both messages when app_proxy config is present', async () => {
+      // Given
+      const config: AppProxyConfigType = {
+        app_proxy: {
+          url: 'https://my-proxy.dev',
+          subpath: 'apps',
+          prefix: 'proxy',
+        },
+      }
+
+      // When
+      const result = await spec.getDevSessionUpdateMessages!(config)
+
+      // Then
+      expect(result).toEqual([
+        'Using URL: https://my-proxy.dev',
+        'Any changes to prefix and subpath will only apply to new installs',
+      ])
+    })
+
+    test('should return empty array when no app_proxy config is present', async () => {
+      // Given
+      const config: AppProxyConfigType = {}
+
+      // When
+      const result = await spec.getDevSessionUpdateMessages!(config)
+
+      // Then
+      expect(result).toEqual([])
+    })
+  })
 })

packages/app/src/cli/models/extensions/specifications/app_config_app_proxy.ts

@@ -13,6 +13,8 @@ const AppProxySchema = BaseSchema.extend({
     .optional(),
 })
 
+export type AppProxyConfigType = zod.infer<typeof AppProxySchema>
+
 export const AppProxySpecIdentifier = 'app_proxy'
 
 const AppProxyTransformConfig: TransformationConfig = {
@@ -26,10 +28,10 @@ const appProxySpec: ExtensionSpecification = createConfigExtensionSpecification(
   schema: AppProxySchema,
   transformConfig: AppProxyTransformConfig,
   getDevSessionUpdateMessages: async (config) => {
-    return [
-      `Using app proxy URL: ${config.app_proxy?.url}`,
-      `Note: Changes to app proxy prefix and subpath won't affect existing installations.`,
-    ]
+    if (!config.app_proxy) {
+      return []
+    }
+    return [`Using URL: ${config.app_proxy.url}`, `Any changes to prefix and subpath will only apply to new installs`]
   },
   patchWithAppDevURLs: (config, urls) => {
     if (urls.appProxy) {

packages/app/src/cli/services/dev/processes/dev-session/dev-session-logger.test.ts

@@ -177,6 +177,7 @@ describe('DevSessionLogger', () => {
         devUUID: '',
         localIdentifier: '',
         idEnvironmentVariableName: '',
+        handle: 'test-extension',
       } as unknown as ExtensionInstance
 
       const event: AppEvent = {
@@ -194,7 +195,7 @@ describe('DevSessionLogger', () => {
       await logger.logExtensionUpdateMessages(event)
       expect(output).toMatchInlineSnapshot(`
         [
-          "└  This has been updated.",
+          "[90m└ [39mThis has been updated.",
         ]
       `)
     })
@@ -206,6 +207,7 @@ describe('DevSessionLogger', () => {
         devUUID: '',
         localIdentifier: '',
         idEnvironmentVariableName: '',
+        handle: 'test-extension',
       } as unknown as ExtensionInstance
 
       const event: AppEvent = {

packages/app/src/cli/services/dev/processes/dev-session/dev-session-logger.ts

@@ -80,15 +80,16 @@ export class DevSessionLogger {
       extensionEvents.map(async (eve) => {
         if (eve.type === EventType.Deleted) return []
         const messages = await eve.extension.getDevSessionUpdateMessages()
-        return messages ?? []
+        return messages?.map((message) => ({message, prefix: eve.extension.handle})) ?? []
       }),
     )
     const messages = messageArrays.flat()
 
     const logPromises = messages.map((message, index) => {
-      const messageContent = outputContent`${outputToken.gray(index === messages.length - 1 ? '└ ' : '│ ')}${message}`
-        .value
-      return this.log(messageContent, 'app-preview')
+      const messageContent = outputContent`${outputToken.gray(index === messages.length - 1 ? '└ ' : '│ ')}${
+        message.message
+      }`.value
+      return this.log(messageContent, message.prefix)
     })
     await Promise.all(logPromises)
   }