Merge pull request #6664 from Shopify/theme-profile-messaging-for-themekit

return an error when using Theme Access password with theme profile

Author: EvilGenius13

.changeset/short-items-see.md

@@ -0,0 +1,5 @@
+---
+'@shopify/theme': patch
+---
+
+Return error when running `theme profile` using a Theme Access password

packages/theme/src/cli/services/profile.test.ts

@@ -82,17 +82,6 @@ describe('profile', () => {
     expect(htmlContent).toContain('speedscope')
   })
 
-  test('uses provided passwords for authentication', async () => {
-    // When
-    await profile(mockAdminSession, themeId, urlPath, true, 'themeAccessPassword', 'storePassword')
-
-    // Then
-    expect(ensureAuthenticatedStorefront).toHaveBeenCalledWith([], 'themeAccessPassword', {
-      forceRefresh: false,
-      noPrompt: true,
-    })
-  })
-
   test('throws error when fetch fails', async () => {
     // Given
     vi.mocked(render).mockRejectedValue(new Error('Network error'))
@@ -120,22 +109,15 @@ describe('profile', () => {
     await expect(result).rejects.toThrow('Bad response: 404: {"error":"Some error message"}')
   })
 
-  test('throws error when an Admin API token is used', async () => {
+  test('throws error when a password is used', async () => {
     // When
     const result = profile(mockAdminSession, themeId, urlPath, true, 'shpat_hello', undefined)
 
     // Then
     await expect(result).rejects.toThrow(
       new AbortError(
-        'Unable to use Admin API tokens with the profile command',
-        `To use this command with the --password flag you must:
-
-1. Install the Theme Access app on your shop
-2. Generate a new password
-
-Alternatively, you can authenticate normally by not passing the --password flag.
-
-Learn more: https://shopify.dev/docs/storefronts/themes/tools/theme-access`,
+        'Unable to use Admin API or Theme Access tokens with the profile command',
+        'You must authenticate manually by not passing the --password flag.',
       ),
     )
   })

packages/theme/src/cli/services/profile.ts

@@ -22,17 +22,10 @@ export async function profile(
     ? await ensureValidPassword(storefrontPassword, adminSession.storeFqdn)
     : undefined
 
-  if (themeAccessPassword?.startsWith('shpat_')) {
+  if (themeAccessPassword) {
     throw new AbortError(
-      'Unable to use Admin API tokens with the profile command',
-      `To use this command with the --password flag you must:
-
-1. Install the Theme Access app on your shop
-2. Generate a new password
-
-Alternatively, you can authenticate normally by not passing the --password flag.
-
-Learn more: https://shopify.dev/docs/storefronts/themes/tools/theme-access`,
+      'Unable to use Admin API or Theme Access tokens with the profile command',
+      'You must authenticate manually by not passing the --password flag.',
     )
   }