refactor(app-config-pull): simplify messaging and config file resolution

Author: anakafeel

packages/app/src/cli/commands/app/config/pull.ts

@@ -3,8 +3,8 @@ import {linkedAppContext} from '../../../services/app-context.js'
 import pull from '../../../services/app/config/pull.js'
 import AppLinkedCommand, {AppLinkedCommandOutput} from '../../../utilities/app-linked-command.js'
 import {renderSuccess} from '@shopify/cli-kit/node/ui'
-import {formatPackageManagerCommand} from '@shopify/cli-kit/node/output'
 import {globalFlags} from '@shopify/cli-kit/node/cli'
+import {basename} from '@shopify/cli-kit/node/path'
 
 export default class ConfigPull extends AppLinkedCommand {
   static summary = 'Refresh an already-linked app configuration without prompts.'
@@ -39,17 +39,7 @@ This command reuses the existing linked app and organization and skips all inter
 
     renderSuccess({
       headline: `Pulled latest configuration for "${configuration.name}"`,
-      body: `Updated ${configuration.path ?? flags.config ?? 'app configuration'} using the already-linked app "${
-        remoteApp.title
-      }".`,
-      nextSteps: [
-        [
-          'To deploy your updated configuration, run',
-          {
-            command: formatPackageManagerCommand(app.packageManager, 'shopify app deploy'),
-          },
-        ],
-      ],
+      body: `Updated ${basename(configuration.path)} with the remote data.`,
     })
 
     return {app}

packages/app/src/cli/services/app/config/pull.ts

@@ -4,7 +4,6 @@ import {LinkOptions, loadLocalAppOptions, overwriteLocalConfigFileWithRemoteAppC
 import {CurrentAppConfiguration, isCurrentAppSchema} from '../../../models/app/app.js'
 import {OrganizationApp} from '../../../models/organization.js'
 import {AppConfigurationFileName, getAppConfigurationFileName} from '../../../models/app/loader.js'
-import {configurationFileNames} from '../../../constants.js'
 import {fetchSpecifications} from '../../generate/fetch-extension-specifications.js'
 import {RemoteAwareExtensionSpecification} from '../../../models/extensions/specification.js'
 import {Flag} from '../../../utilities/developer-platform-client.js'
@@ -55,12 +54,8 @@ export default async function pull(options: PullOptions): Promise<PullOutput> {
 
   const localAppOptions = await loadLocalAppOptions(linkOptions, specifications, flags, remoteApp.apiKey)
 
-  // Decide which config file to overwrite:
-  // - if config has a path, reuse that file
-  // - otherwise, fallback to --config or default app config name
-  const configFileName: AppConfigurationFileName =
-    (configuration.path && (basename(configuration.path) as AppConfigurationFileName)) ||
-    getAppConfigurationFileName(configName ?? configurationFileNames.app)
+  // Decide which config file to overwrite: the configuration should always have a path here.
+  const configFileName: AppConfigurationFileName = basename(configuration.path) as AppConfigurationFileName
 
   const mergedConfiguration = await overwriteLocalConfigFileWithRemoteAppConfiguration({
     remoteApp,