Merge pull request #6008 from Shopify/mza/rm-cc-cert-validation

Remove the encryption certificate content validation from the CLI Schema

Author: manefz

.changeset/fifty-pigs-care.md

@@ -0,0 +1,5 @@
+---
+'@shopify/cli': patch
+---
+
+Fixes the `Encryption certificate fingerprint can't be blank` error when generating a credit card payments extension with the `shopify app generate extension` command.

packages/app/src/cli/models/extensions/specifications/payments_app_extension_schemas/credit_card_payments_app_extension_schema.test.ts

@@ -89,28 +89,6 @@ describe('CreditCardPaymentsAppExtensionSchema', () => {
     )
   })
 
-  test('returns an error if encryption certificate fingerprint is blank', async () => {
-    // When/Then
-    expect(() =>
-      CreditCardPaymentsAppExtensionSchema.parse({
-        ...config,
-        encryption_certificate_fingerprint: '',
-      }),
-    ).toThrowError(
-      new zod.ZodError([
-        {
-          code: zod.ZodIssueCode.too_small,
-          minimum: 1,
-          type: 'string',
-          inclusive: true,
-          exact: false,
-          message: "Encryption certificate fingerprint can't be blank",
-          path: ['encryption_certificate_fingerprint'],
-        },
-      ]),
-    )
-  })
-
   test('returns an error if encryption certificate fingerprint is not present', async () => {
     // When/Then
     // eslint-disable-next-line @typescript-eslint/naming-convention

packages/app/src/cli/models/extensions/specifications/payments_app_extension_schemas/credit_card_payments_app_extension_schema.ts

@@ -33,9 +33,7 @@ export const CreditCardPaymentsAppExtensionSchema = BasePaymentsAppExtensionSche
       required_error: 'supports_moto is required',
       invalid_type_error: 'Value must be Boolean',
     }),
-    encryption_certificate_fingerprint: zod
-      .string()
-      .min(1, {message: "Encryption certificate fingerprint can't be blank"}),
+    encryption_certificate_fingerprint: zod.string(),
     checkout_payment_method_fields: zod
       .array(
         zod.object({