Skip to content

Commit 9f73063

Browse files
committed
Don't prefix with type for info | log
1 parent 3c07e89 commit 9f73063

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

packages/app/src/cli/services/dev/extension/websocket/handlers.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ describe('handleLogEvent()', () => {
280280
}
281281
handleLogEvent(eventData, options)
282282

283-
expectLogMessageOutput('test-extension', `INFO: Test info message`, options)
283+
expectLogMessageOutput('test-extension', `Test info message`, options)
284284
})
285285

286286
test('outputs log message with parsed JSON array', () => {
@@ -296,7 +296,7 @@ describe('handleLogEvent()', () => {
296296

297297
expectLogMessageOutput(
298298
'test-extension',
299-
outputContent`INFO: Hello world ${outputToken.json({user: 'test'})}`.value,
299+
outputContent`Hello world ${outputToken.json({user: 'test'})}`.value,
300300
options,
301301
)
302302
})

packages/app/src/cli/services/dev/extension/websocket/handlers.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,8 @@ const consoleTypeColors = {
7373
error: (text: string) => outputToken.errorText(text),
7474
} as const
7575

76+
const typesToIgnore: ReadonlyArray<string> = ['log', 'info'] as const
77+
7678
export function handleLogEvent(
7779
eventData: {type: string; message: string; extensionName: string},
7880
options: SetupWebSocketConnectionOptions,
@@ -81,10 +83,14 @@ export function handleLogEvent(
8183
const formattedMessage = parseLogMessage(message)
8284

8385
const uppercaseType = type.toUpperCase()
84-
const colouredType = consoleTypeColors[type as keyof typeof consoleTypeColors]?.(uppercaseType) ?? uppercaseType
86+
const coloredType = consoleTypeColors[type as keyof typeof consoleTypeColors]?.(uppercaseType) ?? uppercaseType
87+
88+
const completeMessage = typesToIgnore.includes(type)
89+
? formattedMessage
90+
: outputContent`${coloredType}: ${formattedMessage}`.value
8591

8692
useConcurrentOutputContext({outputPrefix: extensionName, stripAnsi: false}, () => {
87-
options.stdout.write(outputContent`${colouredType}: ${formattedMessage}`.value)
93+
options.stdout.write(completeMessage)
8894
})
8995
}
9096

0 commit comments

Comments
 (0)