Skip to content

Commit a1e2928

Browse files
authored
Merge pull request #6272 from Shopify/08-18-remove_requiresorganization_from_clients
Remove requiresOrganization from clients
2 parents ad2ede7 + 674b9dd commit a1e2928

File tree

5 files changed

+0
-6
lines changed

5 files changed

+0
-6
lines changed

packages/app/src/cli/models/app/app.test-data.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1418,7 +1418,6 @@ export function testDeveloperPlatformClient(stubs: Partial<DeveloperPlatformClie
14181418
const clientStub: DeveloperPlatformClient = {
14191419
clientName: ClientName.AppManagement,
14201420
webUiName: 'Test Dashboard',
1421-
requiresOrganization: false,
14221421
supportsAtomicDeployments: false,
14231422
supportsDevSessions: stubs.supportsDevSessions ?? false,
14241423
supportsStoreSearch: false,
@@ -1505,7 +1504,6 @@ export function testDeveloperPlatformClient(stubs: Partial<DeveloperPlatformClie
15051504
retVal[
15061505
key as keyof Omit<
15071506
DeveloperPlatformClient,
1508-
| 'requiresOrganization'
15091507
| 'supportsAtomicDeployments'
15101508
| 'clientName'
15111509
| 'webUiName'

packages/app/src/cli/services/app/config/link.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,6 @@ async function overwriteLocalConfigFileWithRemoteAppConfiguration(options: {
377377
{
378378
client_id: remoteApp.apiKey,
379379
path: configFilePath,
380-
...(developerPlatformClient.requiresOrganization ? {organization_id: remoteApp.organizationId} : {}),
381380
...remoteAppConfiguration,
382381
},
383382
replaceLocalArrayStrategy,

packages/app/src/cli/utilities/developer-platform-client.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,6 @@ export interface DeveloperPlatformClient {
220220
readonly clientName: ClientName
221221
readonly webUiName: string
222222
readonly supportsAtomicDeployments: boolean
223-
readonly requiresOrganization: boolean
224223
readonly supportsDevSessions: boolean
225224
readonly supportsStoreSearch: boolean
226225
readonly organizationSource: OrganizationSource

packages/app/src/cli/utilities/developer-platform-client/app-management-client.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,6 @@ export interface GatedExtensionTemplate extends ExtensionTemplate {
184184
export class AppManagementClient implements DeveloperPlatformClient {
185185
public readonly clientName = ClientName.AppManagement
186186
public readonly webUiName = 'Developer Dashboard'
187-
public readonly requiresOrganization = true
188187
public readonly supportsAtomicDeployments = true
189188
public readonly supportsDevSessions = true
190189
public readonly supportsStoreSearch = true

packages/app/src/cli/utilities/developer-platform-client/partners-client.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,6 @@ export class PartnersClient implements DeveloperPlatformClient {
214214
public readonly clientName = ClientName.Partners
215215
public readonly webUiName = 'Partner Dashboard'
216216
public readonly supportsAtomicDeployments = false
217-
public readonly requiresOrganization = false
218217
public readonly supportsDevSessions = false
219218
public readonly supportsStoreSearch = false
220219
public readonly organizationSource = OrganizationSource.Partners

0 commit comments

Comments
 (0)