Skip to content

Commit aecb581

Browse files
nickwesselmanericlee878
authored andcommitted
lint fix
1 parent 7f004d4 commit aecb581

File tree

3 files changed

+22
-18
lines changed

3 files changed

+22
-18
lines changed

packages/app/src/cli/services/bulk-operations/execute-bulk-operation.test.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {BULK_OPERATIONS_MIN_API_VERSION} from './constants.js'
77
import {resolveApiVersion} from '../graphql/common.js'
88
import {BulkOperationRunQueryMutation} from '../../api/graphql/bulk-operations/generated/bulk-operation-run-query.js'
99
import {BulkOperationRunMutationMutation} from '../../api/graphql/bulk-operations/generated/bulk-operation-run-mutation.js'
10-
import {OrganizationApp, OrganizationSource} from '../../models/organization.js'
10+
import {OrganizationApp, OrganizationSource, OrganizationStore} from '../../models/organization.js'
1111
import {renderSuccess, renderWarning, renderError, renderInfo} from '@shopify/cli-kit/node/ui'
1212
import {ensureAuthenticatedAdminAsApp} from '@shopify/cli-kit/node/session'
1313
import {inTemporaryDirectory, writeFile} from '@shopify/cli-kit/node/fs'
@@ -24,6 +24,7 @@ vi.mock('../graphql/common.js', async () => {
2424
return {
2525
...actual,
2626
resolveApiVersion: vi.fn(),
27+
validateMutationStore: vi.fn(),
2728
}
2829
})
2930
vi.mock('@shopify/cli-kit/node/ui')
@@ -50,15 +51,14 @@ describe('executeBulkOperation', () => {
5051
} as OrganizationApp
5152

5253
const storeFqdn = 'test-store.myshopify.com'
53-
const mockStore = {
54+
const mockStore: OrganizationStore = {
5455
shopId: '123',
55-
link: 'link',
56+
link: 'https://test-store.myshopify.com/admin',
5657
shopDomain: storeFqdn,
5758
shopName: 'Test Store',
58-
transferDisabled: true,
59+
transferDisabled: false,
5960
convertableToPartnerTest: false,
6061
provisionable: true,
61-
storeType: 'APP_DEVELOPMENT',
6262
}
6363
const mockAdminSession = {token: 'test-token', storeFqdn}
6464

@@ -413,7 +413,7 @@ describe('executeBulkOperation', () => {
413413
await executeBulkOperation({
414414
organization: mockOrganization,
415415
remoteApp: mockRemoteApp,
416-
storeFqdn,
416+
store: mockStore,
417417
query,
418418
watch: false,
419419
})
@@ -440,7 +440,7 @@ describe('executeBulkOperation', () => {
440440
await executeBulkOperation({
441441
organization: mockOrganization,
442442
remoteApp: mockRemoteApp,
443-
storeFqdn,
443+
store: mockStore,
444444
query,
445445
watch: false,
446446
})
@@ -600,7 +600,7 @@ describe('executeBulkOperation', () => {
600600
await executeBulkOperation({
601601
organization: mockOrganization,
602602
remoteApp: mockRemoteApp,
603-
storeFqdn,
603+
store: mockStore,
604604
query,
605605
watch: true,
606606
})
@@ -636,7 +636,7 @@ describe('executeBulkOperation', () => {
636636
await executeBulkOperation({
637637
organization: mockOrganization,
638638
remoteApp: mockRemoteApp,
639-
storeFqdn,
639+
store: mockStore,
640640
query,
641641
watch: true,
642642
})
@@ -672,7 +672,7 @@ describe('executeBulkOperation', () => {
672672
await executeBulkOperation({
673673
organization: mockOrganization,
674674
remoteApp: mockRemoteApp,
675-
storeFqdn,
675+
store: mockStore,
676676
query,
677677
watch: true,
678678
outputFile,

packages/app/src/cli/services/execute-operation.test.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {executeOperation} from './execute-operation.js'
22
import {createAdminSessionAsApp, resolveApiVersion} from './graphql/common.js'
3-
import {OrganizationApp, OrganizationSource} from '../models/organization.js'
3+
import {OrganizationApp, OrganizationSource, OrganizationStore} from '../models/organization.js'
44
import {renderSuccess, renderError, renderSingleTask} from '@shopify/cli-kit/node/ui'
55
import {adminRequestDoc} from '@shopify/cli-kit/node/api/admin'
66
import {ClientError} from 'graphql-request'
@@ -28,12 +28,12 @@ describe('executeOperation', () => {
2828
} as OrganizationApp
2929

3030
const storeFqdn = 'test-store.myshopify.com'
31-
const mockStore = {
31+
const mockStore: OrganizationStore = {
3232
shopId: '123',
33-
link: 'link',
33+
link: 'https://test-store.myshopify.com/admin',
3434
shopDomain: storeFqdn,
3535
shopName: 'Test Store',
36-
transferDisabled: true,
36+
transferDisabled: false,
3737
convertableToPartnerTest: false,
3838
provisionable: true,
3939
storeType: 'APP_DEVELOPMENT',
@@ -127,7 +127,7 @@ describe('executeOperation', () => {
127127
await executeOperation({
128128
organization: mockOrganization,
129129
remoteApp: mockRemoteApp,
130-
storeFqdn,
130+
store: mockStore,
131131
query,
132132
variableFile,
133133
})
@@ -149,7 +149,7 @@ describe('executeOperation', () => {
149149
executeOperation({
150150
organization: mockOrganization,
151151
remoteApp: mockRemoteApp,
152-
storeFqdn,
152+
store: mockStore,
153153
query,
154154
variableFile: nonExistentFile,
155155
}),
@@ -170,7 +170,7 @@ describe('executeOperation', () => {
170170
executeOperation({
171171
organization: mockOrganization,
172172
remoteApp: mockRemoteApp,
173-
storeFqdn,
173+
store: mockStore,
174174
query,
175175
variableFile,
176176
}),

packages/app/src/cli/utilities/developer-platform-client.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,11 @@ export interface DeveloperPlatformClient {
250250
templateSpecifications: (app: MinimalAppIdentifiers) => Promise<ExtensionTemplatesResult>
251251
createApp: (org: Organization, options: CreateAppOptions) => Promise<OrganizationApp>
252252
devStoresForOrg: (orgId: string, searchTerm?: string) => Promise<Paginateable<{stores: OrganizationStore[]}>>
253-
storeByDomain: (orgId: string, shopDomain: string, includeAllStores?: boolean) => Promise<OrganizationStore | undefined>
253+
storeByDomain: (
254+
orgId: string,
255+
shopDomain: string,
256+
includeAllStores?: boolean,
257+
) => Promise<OrganizationStore | undefined>
254258
ensureUserAccessToStore: (orgId: string, store: OrganizationStore) => Promise<void>
255259
appExtensionRegistrations: (
256260
app: MinimalAppIdentifiers,

0 commit comments

Comments
 (0)