Trigger full reload when error overlay needs to be updated

Author: jamesmengo

packages/theme/src/cli/utilities/theme-fs.ts

@@ -2,6 +2,7 @@ import {calculateChecksum} from './asset-checksum.js'
 import {applyIgnoreFilters, getPatternsFromShopifyIgnore} from './asset-ignore.js'
 import {Notifier} from './notifier.js'
 import {createSyncingCatchError} from './errors.js'
+import {emitHotReloadEvent} from './theme-environment/hot-reload/server.js'
 import {DEFAULT_IGNORE_PATTERNS, timestampDateFormat} from '../constants.js'
 import {glob, readFile, ReadOptions, fileExists, mkdir, writeFile, removeFile} from '@shopify/cli-kit/node/fs'
 import {joinPath, basename, relativePath} from '@shopify/cli-kit/node/path'
@@ -150,9 +151,11 @@ export function mountThemeFileSystem(root: string, options?: ThemeFileSystemOpti
 
         if (result?.success) {
           uploadErrors.delete(fileKey)
+          emitHotReloadEvent({type: 'full', key: fileKey})
         } else {
           const errors = result?.errors?.asset ?? ['Response was not successful.']
           uploadErrors.set(fileKey, errors)
+          emitHotReloadEvent({type: 'full', key: fileKey})
           throw new Error(errors.join('\n'))
         }
 

packages/theme/src/cli/utilities/theme-uploader.ts

@@ -2,6 +2,7 @@ import {partitionThemeFiles} from './theme-fs.js'
 import {rejectGeneratedStaticAssets} from './asset-checksum.js'
 import {renderTasksToStdErr} from './theme-ui.js'
 import {createSyncingCatchError, renderThrownError} from './errors.js'
+import {emitHotReloadEvent} from './theme-environment/hot-reload/server.js'
 import {AdminSession} from '@shopify/cli-kit/node/session'
 import {Result, Checksum, Theme, ThemeFileSystem} from '@shopify/cli-kit/node/themes/types'
 import {AssetParams, bulkUploadThemeAssets, deleteThemeAssets} from '@shopify/cli-kit/node/themes/api'
@@ -392,6 +393,7 @@ export function updateUploadErrors(result: Result, localThemeFileSystem: ThemeFi
   } else {
     const errors = result.errors?.asset ?? ['Response was not successful.']
     localThemeFileSystem.uploadErrors.set(result.key, errors)
+    emitHotReloadEvent({type: 'full', key: result.key})
   }
 }