Skip to content

Commit b751fd2

Browse files
committed
Filter non-previewable extensions from the dev-console
1 parent 1cdb37e commit b751fd2

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

packages/app/src/cli/services/dev/extension.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ export async function devUIExtensions(options: ExtensionDevOptions): Promise<voi
136136

137137
const eventHandler = async ({extensionEvents}: AppEvent) => {
138138
for (const event of extensionEvents) {
139+
if (!event.extension.isPreviewable) continue
139140
const status = event.buildResult?.status === 'ok' ? 'success' : 'error'
140141

141142
switch (event.type) {

packages/app/src/cli/services/dev/extension/payload.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,15 @@ export async function getUIExtensionPayload(
3838
},
3939
},
4040
capabilities: {
41-
blockProgress: extension.configuration.capabilities?.block_progress || false,
42-
networkAccess: extension.configuration.capabilities?.network_access || false,
43-
apiAccess: extension.configuration.capabilities?.api_access || false,
41+
blockProgress: extension.configuration.capabilities?.block_progress ?? false,
42+
networkAccess: extension.configuration.capabilities?.network_access ?? false,
43+
apiAccess: extension.configuration.capabilities?.api_access ?? false,
4444
collectBuyerConsent: {
45-
smsMarketing: extension.configuration.capabilities?.collect_buyer_consent?.sms_marketing || false,
46-
customerPrivacy: extension.configuration.capabilities?.collect_buyer_consent?.customer_privacy || false,
45+
smsMarketing: extension.configuration.capabilities?.collect_buyer_consent?.sms_marketing ?? false,
46+
customerPrivacy: extension.configuration.capabilities?.collect_buyer_consent?.customer_privacy ?? false,
4747
},
4848
iframe: {
49-
sources: extension.configuration.capabilities?.iframe?.sources || [],
49+
sources: extension.configuration.capabilities?.iframe?.sources ?? [],
5050
},
5151
},
5252
development: {
@@ -55,14 +55,14 @@ export async function getUIExtensionPayload(
5555
root: {
5656
url,
5757
},
58-
hidden: options.currentDevelopmentPayload?.hidden || false,
58+
hidden: options.currentDevelopmentPayload?.hidden ?? false,
5959
localizationStatus,
60-
status: options.currentDevelopmentPayload?.status || 'success',
61-
...(options.currentDevelopmentPayload || {status: 'success'}),
60+
status: options.currentDevelopmentPayload?.status ?? 'success',
61+
...(options.currentDevelopmentPayload ?? {status: 'success'}),
6262
},
6363
extensionPoints,
6464
localization: localization ?? null,
65-
metafields: extension.configuration.metafields.length === 0 ? null : extension.configuration.metafields,
65+
metafields: extension.configuration.metafields?.length === 0 ? null : extension.configuration.metafields,
6666
type: extension.configuration.type,
6767

6868
externalType: extension.externalType,

0 commit comments

Comments
 (0)