Merge pull request #6282 from Shopify/08-19-webhook_subscriptions_shouldnt_block_dev

Webhook subscriptions shouldnt block dev

Author: isaacroldan

packages/app/src/cli/services/dev.test.ts

@@ -108,6 +108,31 @@ describe('blockIfMigrationIncomplete', () => {
     await expect(blockIfMigrationIncomplete(devConfig)).resolves.toBeUndefined()
   })
 
+  test('does nothing remote extensions dont have uids but are webhook subscriptions', async () => {
+    const developerPlatformClient = testDeveloperPlatformClient({
+      supportsDevSessions: true,
+      async appExtensionRegistrations() {
+        return {
+          app: {
+            extensionRegistrations: [
+              {id: '', uuid: 'u1', title: 'Ext 1', type: 'webhook_subscription'},
+              {id: '2', uuid: 'u2', title: 'Ext 2', type: 'web_pixel_extension'},
+            ],
+            configurationRegistrations: [],
+            dashboardManagedExtensionRegistrations: [],
+          },
+        } as any
+      },
+    })
+
+    const devConfig = {
+      ...baseConfig(),
+      developerPlatformClient,
+    } as any
+
+    await expect(blockIfMigrationIncomplete(devConfig)).resolves.toBeUndefined()
+  })
+
   test('throws AbortError when some remote extensions are missing ids (not migrated)', async () => {
     const developerPlatformClient = testDeveloperPlatformClient({
       supportsDevSessions: true,

packages/app/src/cli/services/dev.ts

@@ -242,7 +242,12 @@ export async function blockIfMigrationIncomplete(devConfig: DevConfig) {
   if (!developerPlatformClient.supportsDevSessions) return
 
   const extensions = (await developerPlatformClient.appExtensionRegistrations(remoteApp)).app.extensionRegistrations
-  if (!extensions.every((extension) => extension.id)) {
+  if (
+    !extensions
+      // Ignore webhook subscriptions because they do need UIDs but shouldn't block dev
+      .filter((extension) => extension.type.toLowerCase() !== 'webhook_subscription')
+      .every((extension) => extension.id)
+  ) {
     const message = ['Your app has extensions which need to be assigned', {command: 'uid'}, 'identifiers.']
     const nextSteps = [
       'You must first map IDs to your existing extensions by running',