Improve regex and tests

Author: isaacroldan

packages/app/src/cli/models/app/app.test.ts

@@ -1,4 +1,5 @@
 import {
+  AppSchema,
   CurrentAppConfiguration,
   LegacyAppConfiguration,
   getAppScopes,
@@ -92,6 +93,33 @@ describe('app schema validation', () => {
 
       expect(isCurrentAppSchema(config)).toBe(false)
     })
+
+    test('extension_directories should be transformed to double asterisks', () => {
+      const config = {
+        ...CORRECT_CURRENT_APP_SCHEMA,
+        extension_directories: ['extensions/*'],
+      }
+      const parsed = AppSchema.parse(config)
+      expect(parsed.extension_directories).toEqual(['extensions/**'])
+    })
+
+    test('extension_directories is not transformed if it ends with double asterisks', () => {
+      const config = {
+        ...CORRECT_CURRENT_APP_SCHEMA,
+        extension_directories: ['extensions/**'],
+      }
+      const parsed = AppSchema.parse(config)
+      expect(parsed.extension_directories).toEqual(['extensions/**'])
+    })
+
+    test('extension_directories is not transformed if it doesnt end with a wildcard', () => {
+      const config = {
+        ...CORRECT_CURRENT_APP_SCHEMA,
+        extension_directories: ['extensions'],
+      }
+      const parsed = AppSchema.parse(config)
+      expect(parsed.extension_directories).toEqual(['extensions'])
+    })
   })
 })
 

packages/app/src/cli/models/app/app.ts

@@ -59,7 +59,8 @@ function removeTrailingPathSeparator(value: string[] | undefined) {
 // If a path ends with a single asterisk, modify it to end with a double asterisk.
 // This is to support the glob pattern used by chokidar and watch for changes in subfolders.
 function fixSingleWildcards(value: string[] | undefined) {
-  return value?.map((dir) => dir.replace(/\*$/, '**'))
+  // eslint-disable-next-line no-useless-escape
+  return value?.map((dir) => dir.replace(/([^\*])\*$/, '$1**'))
 }
 
 /**