Merge pull request #6061 from Shopify/07-03-replace_http-proxy_with_http-proxy-node16

replace http-proxy with http-proxy-node16

Author: isaacroldan

packages/app/package.json

@@ -68,7 +68,7 @@
     "express": "4.21.2",
     "graphql-request": "6.1.0",
     "h3": "0.7.21",
-    "http-proxy": "1.18.1",
+    "http-proxy-node16": "^1.0.6",
     "ignore": "6.0.2",
     "proper-lockfile": "4.1.2",
     "react": "^18.2.0",
@@ -80,7 +80,6 @@
     "@types/body-parser": "^1.19.2",
     "@types/diff": "^5.0.3",
     "@types/express": "^4.17.17",
-    "@types/http-proxy": "^1.17.11",
     "@types/proper-lockfile": "4.1.4",
     "@types/react": "18.2.0",
     "@types/react-dom": "18.2.0",

packages/app/src/cli/utilities/app/http-reverse-proxy.ts

@@ -1,10 +1,10 @@
 import {AbortController} from '@shopify/cli-kit/node/abort'
 import {outputDebug, outputContent, outputToken, outputWarn} from '@shopify/cli-kit/node/output'
-import Server from 'http-proxy'
 import {useConcurrentOutputContext} from '@shopify/cli-kit/node/ui/components'
 import * as http from 'http'
 import * as https from 'https'
 import {Writable} from 'stream'
+import type Server from 'http-proxy-node16'
 
 export interface LocalhostCert {
   key: string
@@ -20,8 +20,8 @@ export async function getProxyingWebServer(
 ) {
   // Lazy-importing it because it's CJS and we don't want it
   // to block the loading of the ESM module graph.
-  const {default: httpProxy} = await import('http-proxy')
-  const proxy = httpProxy.createProxy()
+  const httpProxy = await import('http-proxy-node16')
+  const proxy = httpProxy.default.createProxyServer()
 
   const requestListener = getProxyServerRequestListener(rules, proxy, stdout)