Skip to content

Commit bcac21c

Browse files
committed
feat: include request id in errors if present
1 parent f594242 commit bcac21c

File tree

1 file changed

+16
-1
lines changed

1 file changed

+16
-1
lines changed

packages/theme/src/cli/utilities/theme-command.ts

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import {
1616
import {AbortController} from '@shopify/cli-kit/node/abort'
1717
import {AbortError} from '@shopify/cli-kit/node/error'
1818
import {recordEvent, compileData} from '@shopify/cli-kit/node/analytics'
19-
import {addPublicMetadata, addSensitiveMetadata} from '@shopify/cli-kit/node/metadata'
19+
import {addPublicMetadata, addSensitiveMetadata, getAllPublicMetadata} from '@shopify/cli-kit/node/metadata'
2020
import {cwd, joinPath, resolvePath} from '@shopify/cli-kit/node/path'
2121
import {fileExistsSync} from '@shopify/cli-kit/node/fs'
2222
import {normalizeStoreFqdn} from '@shopify/cli-kit/node/context/fqdn'
@@ -60,6 +60,21 @@ export default abstract class ThemeCommand extends Command {
6060
_context?: {stdout?: Writable; stderr?: Writable},
6161
): Promise<void> {}
6262

63+
async catch(error: Error & {skipOclifErrorHandling: boolean}): Promise<void> {
64+
const metadata = getAllPublicMetadata()
65+
const requestId = metadata.cmd_all_last_graphql_request_id
66+
67+
if (
68+
requestId &&
69+
/** Request id may have alreayd been added by `packages/cli-kit/src/private/node/api/graphql.ts` */
70+
!error.message.includes('Request ID:')
71+
) {
72+
error.message += `\n\nRequest ID: ${requestId}`
73+
}
74+
75+
return super.catch(error)
76+
}
77+
6378
async run<
6479
TFlags extends FlagOutput & {path?: string; verbose?: boolean},
6580
TGlobalFlags extends FlagOutput,

0 commit comments

Comments
 (0)