Skip to content

Commit cedc213

Browse files
authored
Merge pull request #6123 from Shopify/rz-fix-domain-for-local-dev
Use apropriate shop domain name in different environment
2 parents 9907280 + 51b40da commit cedc213

File tree

5 files changed

+7
-24
lines changed

5 files changed

+7
-24
lines changed

packages/store/src/services/store/operations/store-copy.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import {FlagOptions} from '../../../lib/types.js'
33
import {BulkDataStoreCopyStartResponse, BulkDataOperationByIdResponse} from '../../../apis/organizations/types.js'
44
import {parseResourceConfigFlags} from '../../../lib/resource-config.js'
55
import {confirmCopyPrompt} from '../../../prompts/confirm_copy.js'
6-
import {storeFullDomain} from '../utils/store-utils.js'
76
import {ApiClient} from '../api/api-client.js'
87
import {ApiClientInterface} from '../types/api-client.js'
98
import {BulkOperationTaskGenerator, BulkOperationContext} from '../utils/bulk-operation-task-generator.js'
@@ -12,6 +11,7 @@ import {renderCopyInfo} from '../../../prompts/copy_info.js'
1211
import {renderCopyResult} from '../../../prompts/copy_result.js'
1312
import {outputInfo} from '@shopify/cli-kit/node/output'
1413
import {Task, renderTasks} from '@shopify/cli-kit/node/ui'
14+
import {normalizeStoreFqdn} from '@shopify/cli-kit/node/context/fqdn'
1515

1616
export class StoreCopyOperation implements StoreOperation {
1717
fromArg: string | undefined
@@ -28,8 +28,8 @@ export class StoreCopyOperation implements StoreOperation {
2828
this.fromArg = fromStore
2929
this.toArg = toStore
3030

31-
const sourceShopDomain = storeFullDomain(fromStore)
32-
const targetShopDomain = storeFullDomain(toStore)
31+
const sourceShopDomain = await normalizeStoreFqdn(fromStore)
32+
const targetShopDomain = await normalizeStoreFqdn(toStore)
3333

3434
const apiShopId = await this.validateShops(sourceShopDomain, targetShopDomain)
3535

packages/store/src/services/store/operations/store-export.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import {StoreOperation} from '../types/operations.js'
22
import {FlagOptions} from '../../../lib/types.js'
33
import {BulkDataStoreExportStartResponse, BulkDataOperationByIdResponse} from '../../../apis/organizations/types.js'
44
import {Organization} from '../../../apis/destinations/index.js'
5-
import {storeFullDomain} from '../utils/store-utils.js'
65
import {ResultFileHandler} from '../utils/result-file-handler.js'
76
import {ApiClient} from '../api/api-client.js'
87
import {ApiClientInterface} from '../types/api-client.js'
@@ -14,6 +13,7 @@ import {confirmExportPrompt} from '../../../prompts/confirm_export.js'
1413
import {Task, renderTasks} from '@shopify/cli-kit/node/ui'
1514
import {outputInfo} from '@shopify/cli-kit/node/output'
1615
import {fileExistsSync} from '@shopify/cli-kit/node/fs'
16+
import {normalizeStoreFqdn} from '@shopify/cli-kit/node/context/fqdn'
1717

1818
export class StoreExportOperation implements StoreOperation {
1919
fromArg: string | undefined
@@ -32,7 +32,7 @@ export class StoreExportOperation implements StoreOperation {
3232
async execute(fromStore: string, toFile: string, flags: FlagOptions): Promise<void> {
3333
this.fromArg = fromStore
3434

35-
const sourceShopDomain = storeFullDomain(fromStore)
35+
const sourceShopDomain = await normalizeStoreFqdn(fromStore)
3636

3737
const apiShopId = await this.validateShop(sourceShopDomain)
3838

packages/store/src/services/store/operations/store-import.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import {StoreOperation} from '../types/operations.js'
22
import {FlagOptions} from '../../../lib/types.js'
33
import {BulkDataStoreImportStartResponse, BulkDataOperationByIdResponse} from '../../../apis/organizations/types.js'
44
import {parseResourceConfigFlags} from '../../../lib/resource-config.js'
5-
import {storeFullDomain} from '../utils/store-utils.js'
65
import {FileUploader} from '../utils/file-uploader.js'
76
import {MockFileUploader} from '../utils/mock-file-uploader.js'
87
import {ApiClient} from '../api/api-client.js'
@@ -15,6 +14,7 @@ import {confirmImportPrompt} from '../../../prompts/confirm_import.js'
1514
import {outputInfo} from '@shopify/cli-kit/node/output'
1615
import {Task, renderTasks} from '@shopify/cli-kit/node/ui'
1716
import {fileExists} from '@shopify/cli-kit/node/fs'
17+
import {normalizeStoreFqdn} from '@shopify/cli-kit/node/context/fqdn'
1818

1919
export class StoreImportOperation implements StoreOperation {
2020
fromArg: string | undefined
@@ -39,7 +39,7 @@ export class StoreImportOperation implements StoreOperation {
3939

4040
await this.validateInputFile(fromFile)
4141

42-
const targetShopDomain = storeFullDomain(toStore)
42+
const targetShopDomain = await normalizeStoreFqdn(toStore)
4343
const apiShopId = await this.validateShop(targetShopDomain)
4444

4545
if (!flags['no-prompt']) {

packages/store/src/services/store/utils/store-utils.test.ts

Lines changed: 0 additions & 14 deletions
This file was deleted.

packages/store/src/services/store/utils/store-utils.ts

Lines changed: 0 additions & 3 deletions
This file was deleted.

0 commit comments

Comments
 (0)