Do not update the alias anymore

Author: gonzaloriestra

packages/app/src/cli/utilities/developer-platform-client/app-management-client.ts

@@ -25,7 +25,7 @@ import {
   DevSessionDeleteOptions,
   UserError,
 } from '../developer-platform-client.js'
-import {getAlias, PartnersSession} from '../../services/context/partner-account-info.js'
+import {PartnersSession} from '../../services/context/partner-account-info.js'
 import {
   MinimalAppIdentifiers,
   MinimalOrganizationApp,
@@ -139,10 +139,7 @@ import {
 } from '../../api/graphql/app-management/generated/app-logs-subscribe.js'
 import {SourceExtension} from '../../api/graphql/app-management/generated/types.js'
 import {getPartnersToken} from '@shopify/cli-kit/node/environment'
-import {
-  ensureAuthenticatedAppManagementAndBusinessPlatform,
-  updateSessionAliasIfEmpty,
-} from '@shopify/cli-kit/node/session'
+import {ensureAuthenticatedAppManagementAndBusinessPlatform} from '@shopify/cli-kit/node/session'
 import {isUnitTest} from '@shopify/cli-kit/node/context/local'
 import {AbortError, BugError} from '@shopify/cli-kit/node/error'
 import {fetch, shopifyFetch, Response} from '@shopify/cli-kit/node/http'
@@ -317,8 +314,6 @@ export class AppManagementClient implements DeveloperPlatformClient {
           userId,
         }
       }
-
-      await updateSessionAliasIfEmpty(userId, getAlias(this._session.accountInfo))
     }
     return this._session
   }

packages/app/src/cli/utilities/developer-platform-client/partners-client.ts

@@ -14,11 +14,7 @@ import {
   AppLogsResponse,
   createUnauthorizedHandler,
 } from '../developer-platform-client.js'
-import {
-  fetchCurrentAccountInformation,
-  getAlias,
-  PartnersSession,
-} from '../../../cli/services/context/partner-account-info.js'
+import {fetchCurrentAccountInformation, PartnersSession} from '../../../cli/services/context/partner-account-info.js'
 import {
   MinimalAppIdentifiers,
   MinimalOrganizationApp,
@@ -163,7 +159,7 @@ import {isUnitTest} from '@shopify/cli-kit/node/context/local'
 import {AbortError} from '@shopify/cli-kit/node/error'
 import {generateFetchAppLogUrl, partnersRequest, partnersRequestDoc} from '@shopify/cli-kit/node/api/partners'
 import {CacheOptions, GraphQLVariables, UnauthorizedHandler} from '@shopify/cli-kit/node/api/graphql'
-import {ensureAuthenticatedPartners, updateSessionAliasIfEmpty} from '@shopify/cli-kit/node/session'
+import {ensureAuthenticatedPartners} from '@shopify/cli-kit/node/session'
 import {partnersFqdn} from '@shopify/cli-kit/node/context/fqdn'
 import {TokenItem} from '@shopify/cli-kit/node/ui'
 import {RequestModeInput, Response, shopifyFetch} from '@shopify/cli-kit/node/http'
@@ -243,8 +239,6 @@ export class PartnersClient implements DeveloperPlatformClient {
       }
       const accountInfo = await fetchCurrentAccountInformation(this, userId)
       this._session = {token, businessPlatformToken: '', accountInfo, userId}
-
-      await updateSessionAliasIfEmpty(userId, getAlias(accountInfo))
     }
     return this._session
   }

packages/cli-kit/src/public/node/session.test.ts

@@ -5,7 +5,6 @@ import {
   ensureAuthenticatedPartners,
   ensureAuthenticatedStorefront,
   ensureAuthenticatedThemes,
-  updateSessionAliasIfEmpty,
 } from './session.js'
 
 import {getPartnersToken} from './environment.js'
@@ -16,7 +15,6 @@ import {
   exchangeCliTokenForAppManagementAccessToken,
   exchangeCliTokenForBusinessPlatformAccessToken,
 } from '../../private/node/session/exchange.js'
-import * as sessionStore from '../../private/node/session/store.js'
 import {vi, describe, expect, test} from 'vitest'
 
 const futureDate = new Date(2022, 1, 1, 11)
@@ -273,47 +271,3 @@ describe('ensureAuthenticatedAppManagementAndBusinessPlatform', () => {
     expect(ensureAuthenticated).not.toHaveBeenCalled()
   })
 })
-
-describe('updateSessionAliasIfEmpty', () => {
-  test('updates alias when current alias is empty', async () => {
-    // Given
-    vi.mocked(sessionStore.getSessionAlias).mockResolvedValue(undefined)
-
-    // When
-    await updateSessionAliasIfEmpty('user1', 'New Alias')
-
-    // Then
-    expect(sessionStore.getSessionAlias).toHaveBeenCalledWith('user1')
-    expect(sessionStore.updateSessionAlias).toHaveBeenCalledWith('user1', 'New Alias')
-  })
-
-  test('does not update alias when current alias exists', async () => {
-    // Given
-    vi.mocked(sessionStore.getSessionAlias).mockResolvedValue('Existing Alias')
-
-    // When
-    await updateSessionAliasIfEmpty('user1', 'New Alias')
-
-    // Then
-    expect(sessionStore.getSessionAlias).toHaveBeenCalledWith('user1')
-    expect(sessionStore.updateSessionAlias).not.toHaveBeenCalled()
-  })
-
-  test('does nothing when alias parameter is undefined', async () => {
-    // When
-    await updateSessionAliasIfEmpty('user1', undefined)
-
-    // Then
-    expect(sessionStore.getSessionAlias).not.toHaveBeenCalled()
-    expect(sessionStore.updateSessionAlias).not.toHaveBeenCalled()
-  })
-
-  test('does nothing when alias parameter is empty string', async () => {
-    // When
-    await updateSessionAliasIfEmpty('user1', '')
-
-    // Then
-    expect(sessionStore.getSessionAlias).not.toHaveBeenCalled()
-    expect(sessionStore.updateSessionAlias).not.toHaveBeenCalled()
-  })
-})

packages/cli-kit/src/public/node/session.ts

@@ -235,19 +235,3 @@ ${outputToken.json(scopes)}
 export function logout(): Promise<void> {
   return sessionStore.remove()
 }
-
-/**
- * Updates the session alias with a more human-readable display name if available.
- * Only updates if the current alias is empty.
- *
- * @param userId - The user ID of the session to update.
- * @param alias - The alias to update the session with.
- * @returns Promise that resolves when the alias update is complete.
- */
-export async function updateSessionAliasIfEmpty(userId: string, alias: string | undefined): Promise<void> {
-  if (!alias) return
-  const currentAlias = await sessionStore.getSessionAlias(userId)
-  if (!currentAlias) {
-    await sessionStore.updateSessionAlias(userId, alias)
-  }
-}