Merge pull request #5330 from Shopify/drop-cross-env

Drop cross-env

Author: gonzaloriestra

package.json

@@ -11,7 +11,7 @@
     "changeset-build-no-docs": "changeset version && pnpm install --no-frozen-lockfile && pnpm build && bin/update-cli-kit-version.js",
     "changeset-manifests": "changeset version && pnpm install --no-frozen-lockfile && pnpm refresh-manifests && pnpm refresh-readme && pnpm refresh-code-documentation && bin/update-cli-kit-version.js",
     "clean": "nx run-many --target=clean --all --skip-nx-cache && nx reset",
-    "create-app": "nx build create-app && cross-env SHOPIFY_FLAG_PACKAGE_MANAGER=npm node packages/create-app/bin/dev.js",
+    "create-app": "nx build create-app && node packages/create-app/bin/dev.js --package-manager npm",
     "deploy-experimental": "node bin/deploy-experimental.js",
     "graph": "nx graph",
     "graphql-codegen:get-graphql-schemas": "bin/get-graphql-schemas.js",
@@ -54,7 +54,6 @@
     "ansi-colors": "^4.1.3",
     "bugsnag-build-reporter": "^2.0.0",
     "commander": "^9.4.0",
-    "cross-env": "^7.0.3",
     "esbuild": "0.24.2",
     "eslint": "^8.48.0",
     "execa": "^7.2.0",

packages/app/package.json

@@ -37,7 +37,7 @@
     "clean": "nx clean",
     "lint": "nx lint",
     "lint:fix": "nx lint:fix",
-    "prepack": "cross-env NODE_ENV=production pnpm nx build && cp ../../README.md README.md",
+    "prepack": "NODE_ENV=production pnpm nx build && cp ../../README.md README.md",
     "test": "nx run app:test",
     "test:coverage": "nx test:coverage",
     "test:watch": "nx test:watch",

packages/cli-kit/package.json

@@ -51,7 +51,7 @@
     "open-api-docs": "nx open-api-docs",
     "lint": "nx lint",
     "lint:fix": "nx lint:fix",
-    "prepack": "cross-env NODE_ENV=production pnpm nx build && cp ../../README.md README.md",
+    "prepack": "NODE_ENV=production pnpm nx build && cp ../../README.md README.md",
     "test": "nx test",
     "test:js": "nx test:js",
     "test:coverage": "nx test:coverage",

packages/cli/package.json

@@ -46,7 +46,7 @@
     "clean": "nx clean",
     "lint": "nx lint",
     "lint:fix": "nx lint:fix",
-    "prepack": "cross-env NODE_ENV=production node ../../bin/update-bugsnag cli && cp ../../README.md README.md",
+    "prepack": "NODE_ENV=production node ../../bin/update-bugsnag cli && cp ../../README.md README.md",
     "test": "nx run cli:test",
     "test:coverage": "nx test:coverage",
     "test:watch": "nx test:watch",

packages/create-app/package.json

@@ -45,7 +45,7 @@
     "clean": "nx clean",
     "lint": "nx lint",
     "lint:fix": "nx lint:fix",
-    "prepack": "cross-env NODE_ENV=production node ../../bin/update-bugsnag create-app && cp ../../README.md README.md",
+    "prepack": "NODE_ENV=production node ../../bin/update-bugsnag create-app && cp ../../README.md README.md",
     "test": "nx run create-app:test",
     "test:watch": "nx test:watch",
     "type-check": "nx type-check"

packages/features/package.json

@@ -8,7 +8,7 @@
     "lint": "nx lint",
     "lint:fix": "nx lint:fix",
     "test": "nx run features:test",
-    "cucumber-esm": "cross-env NODE_OPTIONS=\"--loader ts-node/esm\" cucumber-js",
+    "cucumber": "cucumber-js",
     "type-check": "nx type-check"
   },
   "eslintConfig": {

packages/features/project.json

@@ -10,8 +10,11 @@
       "executor": "nx:run-commands",
       "dependsOn": ["^build"],
       "options": {
-        "command": "pnpm cucumber-esm",
-        "cwd": "packages/features"
+        "command": "pnpm cucumber",
+        "cwd": "packages/features",
+        "env": {
+          "NODE_OPTIONS": "--loader ts-node/esm"
+        }
       }
     },
     "lint": {

packages/plugin-cloudflare/package.json

@@ -36,7 +36,7 @@
     "clean": "nx clean",
     "lint": "nx lint",
     "lint:fix": "nx lint:fix",
-    "prepack": "cross-env NODE_ENV=production pnpm nx build && cp ../../README.md README.md",
+    "prepack": "NODE_ENV=production pnpm nx build && cp ../../README.md README.md",
     "test": "nx run plugin-cloudflare:test",
     "test:watch": "nx test:watch",
     "type-check": "nx type-check"

packages/plugin-did-you-mean/package.json

@@ -31,7 +31,7 @@
     "clean": "nx clean",
     "lint": "nx lint",
     "lint:fix": "nx lint:fix",
-    "prepack": "cross-env NODE_ENV=production pnpm nx build && cp ../../README.md README.md",
+    "prepack": "NODE_ENV=production pnpm nx build && cp ../../README.md README.md",
     "test": "nx run plugin-did-you-mean:test",
     "test:watch": "nx test:watch",
     "type-check": "nx type-check"

packages/theme/package.json

@@ -31,7 +31,7 @@
     "clean": "nx clean",
     "lint": "nx lint",
     "lint:fix": "nx lint:fix",
-    "prepack": "cross-env NODE_ENV=production pnpm nx build && cp ../../README.md README.md",
+    "prepack": "NODE_ENV=production pnpm nx build && cp ../../README.md README.md",
     "test": "nx run theme:test",
     "test:watch": "nx test:watch",
     "type-check": "nx type-check"