Skip to content

Commit e24b4a2

Browse files
authored
Merge pull request #7145 from Shopify/04-01-add_user_aborted_a_request_to_errormessageimpliesenvironmentissue
Add user aborted a request to errorMessageImpliesEnvironmentIssue
2 parents 4ed0ce1 + c22cf11 commit e24b4a2

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

packages/cli-kit/src/public/node/error.test.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,4 +70,8 @@ describe('shouldReportErrorAsUnexpected helper', () => {
7070
test('returns false for errors that imply environment issues', () => {
7171
expect(shouldReportErrorAsUnexpected(new Error('EPERM: operation not permitted, scandir'))).toBe(false)
7272
})
73+
74+
test('returns false for user-aborted requests', () => {
75+
expect(shouldReportErrorAsUnexpected(new Error('The user aborted a request.'))).toBe(false)
76+
})
7377
})

packages/cli-kit/src/public/node/error.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,7 @@ function errorMessageImpliesEnvironmentIssue(message: string): boolean {
233233
'Client network socket disconnected before secure TLS connection was established',
234234
'spawn EPERM',
235235
'socket hang up',
236+
'The user aborted a request.',
236237
]
237238
const anyMatches = environmentIssueMessages.some((issueMessage) => message.includes(issueMessage))
238239
return anyMatches

0 commit comments

Comments
 (0)