Skip to content

Commit e27ed44

Browse files
skip current identity uptime check
1 parent c356b4e commit e27ed44

File tree

3 files changed

+4
-11
lines changed

3 files changed

+4
-11
lines changed

packages/cli-kit/src/public/node/context/fqdn.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import {AbortError, BugError} from '../error.js'
22
import {serviceEnvironment} from '../../../private/node/context/service.js'
33
import {DevServer, DevServerCore} from '../vendor/dev_server/index.js'
44
import {blockPartnersAccess} from '../environment.js'
5+
import {setAssertRunning} from '../vendor/dev_server/dev-server-2024.js'
56

67
export const NotProvidedStoreFQDNError = new AbortError(
78
"Couldn't obtain the Shopify FQDN because the store FQDN was not provided.",
@@ -115,6 +116,8 @@ export async function identityFqdn(): Promise<string> {
115116
const productionFqdn = 'accounts.shopify.com'
116117
switch (environment) {
117118
case 'local':
119+
// force identity uptime check to pass
120+
setAssertRunning((projectName) => projectName === 'identity')
118121
return new DevServer('identity').host()
119122
default:
120123
return productionFqdn

packages/cli-kit/src/public/node/vendor/dev_server/network/host.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,3 @@ export function getIpFromHosts(hostname: string) {
4848

4949
throw new Error(`No IP found for hostname: ${hostname}`)
5050
}
51-
52-
// eslint-disable-next-line @typescript-eslint/naming-convention
53-
export function TEST_ClearCache() {
54-
hostToIpCache = {}
55-
lastModifiedTime = 0
56-
}

packages/cli-kit/src/public/node/vendor/dev_server/network/index.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ let checkPort: ReturnType<typeof getCheckPortHelper>
1818

1919
export function assertConnectable(options: ConnectionArguments): void {
2020
checkPort ||= getCheckPortHelper()
21+
debugger
2122

2223
const {port, addr, timeout = DEFAULT_CONNECT_TIMEOUT} = options
2324
try {
@@ -33,11 +34,6 @@ export function assertConnectable(options: ConnectionArguments): void {
3334
}
3435
}
3536

36-
// eslint-disable-next-line @typescript-eslint/naming-convention
37-
export function TEST_testResetCheckPort(): void {
38-
checkPort = getCheckPortHelper()
39-
}
40-
4137
function getCheckPortHelper(): (addr: string, port: number, timeout: number) => boolean {
4238
return fallbackCheckPort
4339
}

0 commit comments

Comments
 (0)