Merge pull request #5122 from Shopify/remove-remaining-app-id-references

amcaplan · web-flow · commit e72a072f8ebf · 2025-01-07T09:03:37.000Z
Remove remaining refs to app ID when only API key is needed
diff --git a/packages/app/src/cli/services/app/config/link.ts b/packages/app/src/cli/services/app/config/link.ts
@@ -137,7 +137,6 @@ async function selectOrCreateRemoteAppToLinkTo(options: LinkOptions): Promise<{
     // Remote API Key provided by the caller, so use that app specifically
     const remoteApp = await appFromIdentifiers({
       apiKey: options.apiKey,
-      id: options.appId,
       developerPlatformClient,
       organizationId: options.organizationId,
     })
diff --git a/packages/app/src/cli/services/context.ts b/packages/app/src/cli/services/context.ts
@@ -46,7 +46,6 @@ export const resetHelpMessage: Token[] = [
 
 interface AppFromIdOptions {
   apiKey: string
-  id?: string
   organizationId?: string
   developerPlatformClient: DeveloperPlatformClient
 }

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,6 @@ export const resetHelpMessage: Token[] = [`
`46`	`46`
`47`	`47`	`interface AppFromIdOptions {`
`48`	`48`	`apiKey: string`
`49`		`- id?: string`
`50`	`49`	`organizationId?: string`
`51`	`50`	`developerPlatformClient: DeveloperPlatformClient`
`52`	`51`	`}`