Fix theme package trying to use default environment

The package command does not support an environment flag and would fail
if a default environment was present in a users `shopify.theme.toml`
because we try to load it automatically.

This adds an early return if we're using the default environment but the
command doesn't support it.

Author: graygilmore

.changeset/twelve-crabs-bake.md

@@ -0,0 +1,5 @@
+---
+'@shopify/cli-kit': patch
+---
+
+Fix an issue with running `theme package` with a default environment present

packages/cli-kit/src/public/node/base-command.test.ts

@@ -69,6 +69,32 @@ class MockCommandWithRequiredFlagInNonTTY extends MockCommand {
   }
 }
 
+class MockCommandWithoutEnvironmentFlag extends Command {
+  /* eslint-disable @shopify/cli/command-flags-with-env */
+  static flags = {
+    ...globalFlags,
+    path: Flags.string({
+      parse: async (input) => resolvePath(input),
+      default: async () => cwd(),
+    }),
+    someString: Flags.string({}),
+  }
+  /* eslint-enable @shopify/cli/command-flags-with-env */
+
+  async run(): Promise<void> {
+    const {flags} = await this.parse(MockCommandWithoutEnvironmentFlag)
+    testResult = flags
+  }
+
+  async catch(error: Error): Promise<void> {
+    testError = error
+  }
+
+  environmentsFilename(): string {
+    return 'shopify.environments.toml'
+  }
+}
+
 const validEnvironment = {
   someString: 'stringy',
   someBoolean: true,
@@ -233,6 +259,23 @@ describe('applying environments', async () => {
     `)
   })
 
+  describe('when the command does not support the environment flag', () => {
+    runTestInTmpDir('does not apply default environment', async (tmpDir: string) => {
+      // Given
+      const outputMock = mockAndCaptureOutput()
+      outputMock.clear()
+
+      // When
+      await MockCommandWithoutEnvironmentFlag.run(['--path', tmpDir])
+
+      // Then
+      expect(testResult).toMatchObject({
+        path: resolvePath(tmpDir),
+      })
+      expect(testResult.environment).toBeUndefined()
+    })
+  })
+
   runTestInTmpDir(
     'base Command does not apply environment specified via environment variable',
     async (tmpDir: string) => {

packages/cli-kit/src/public/node/base-command.ts

@@ -166,6 +166,7 @@ This flag is required in non-interactive terminal environments, such as a CI env
     )
 
     if (!environment) return originalResult
+    if (isDefaultEnvironment && !commandSupportsFlag(options?.flags, 'environment')) return originalResult
 
     // Parse using noDefaultsOptions to derive a list of flags specified as
     // command-line arguments.
@@ -307,7 +308,7 @@ function argsFromEnvironment<TFlags extends FlagOutput, TGlobalFlags extends Fla
 ): string[] {
   const args: string[] = []
   for (const [label, value] of Object.entries(environment)) {
-    const flagIsRelevantToCommand = options?.flags && Object.prototype.hasOwnProperty.call(options.flags, label)
+    const flagIsRelevantToCommand = commandSupportsFlag(options?.flags, label)
     const userSpecifiedThisFlag =
       noDefaultsResult.flags && Object.prototype.hasOwnProperty.call(noDefaultsResult.flags, label)
     if (flagIsRelevantToCommand && !userSpecifiedThisFlag) {
@@ -331,4 +332,8 @@ function argsFromEnvironment<TFlags extends FlagOutput, TGlobalFlags extends Fla
   return args
 }
 
+function commandSupportsFlag(flags: FlagInput | undefined, flagName: string): boolean {
+  return Boolean(flags) && Object.prototype.hasOwnProperty.call(flags, flagName)
+}
+
 export default BaseCommand