Skip to content

Commit f037172

Browse files
authored
Merge pull request #6298 from Shopify/theme-app-extension-request-logs
Remove request logs from theme app extensions development server
2 parents 9d650de + e301450 commit f037172

File tree

4 files changed

+11
-4
lines changed

4 files changed

+11
-4
lines changed

.changeset/bright-lobsters-grow.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@shopify/theme': patch
3+
---
4+
5+
Remove request logs from the theme app extensions development server for a cleaner developer experience

packages/theme/src/cli/utilities/log-request-line.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import {timestampDateFormat} from '../constants.js'
44
import {outputContent, outputInfo, outputToken} from '@shopify/cli-kit/node/output'
55
import {H3Event} from 'h3'
66
import {extname} from '@shopify/cli-kit/node/path'
7+
import type {DevServerContext} from './theme-environment/types.js'
78

89
const CHARACTER_TRUNCATION_LIMIT = 80
910

@@ -12,8 +13,9 @@ interface MinimalResponse {
1213
headers: {get: (key: string) => string | null}
1314
}
1415

15-
export function logRequestLine(event: H3Event, response: MinimalResponse) {
16+
export function logRequestLine(event: H3Event, response: MinimalResponse, ctx: DevServerContext) {
1617
if (!shouldLog(event)) return
18+
if (ctx.type === 'theme-extension') return
1719

1820
const truncatedPath =
1921
event.path.length > CHARACTER_TRUNCATION_LIMIT

packages/theme/src/cli/utilities/theme-environment/html.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,12 @@ export function getHtmlHandler(theme: Theme, ctx: DevServerContext): EventHandle
5858
// Fallback to proxying to see if that works:
5959
const proxyResponse = await tryProxyRequest(event, ctx, response)
6060
if (proxyResponse) {
61-
logRequestLine(event, proxyResponse)
61+
logRequestLine(event, proxyResponse, ctx)
6262
return proxyResponse
6363
}
6464
}
6565

66-
logRequestLine(event, response)
66+
logRequestLine(event, response, ctx)
6767

6868
return patchRenderingResponse(ctx, response, (body) => {
6969
assertThemeId(response, body, String(theme.id))

packages/theme/src/cli/utilities/theme-environment/proxy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ export function getProxyHandler(_theme: Theme, ctx: DevServerContext) {
4747

4848
return proxyStorefrontRequest(event, ctx)
4949
.then(async (response) => {
50-
logRequestLine(event, response)
50+
logRequestLine(event, response, ctx)
5151

5252
if (response.ok) {
5353
const fileName = pathname.split('/').at(-1) ?? ''

0 commit comments

Comments
 (0)