Skip to content

Commit f7a5f18

Browse files
Merge pull request #6329 from Shopify/simplify-snapit
Simplify snapit message
2 parents f022aac + 7fb3e46 commit f7a5f18

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

.github/workflows/snapit.yml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,16 +26,11 @@ jobs:
2626
- name: Force snapshot changeset
2727
run: "mv .changeset/force-snapshot-build.md.ignore .changeset/force-snapshot-build.md"
2828
- name: Create snapshot version
29-
uses: Shopify/snapit@8ff75631e13281a35f85b373bcadfa2fa12bb21e # [email protected]
29+
uses: Shopify/snapit@registry-and-package-manager
3030
with:
3131
global_install: 'true'
3232
github_comment_included_packages: '@shopify/cli'
3333
custom_message_suffix: "
34-
> [!TIP]
35-
36-
> If you get an `ETARGET` error, install it with NPM and the flag `--@shopify:registry=https://registry.npmjs.org`
37-
38-
3934
> [!CAUTION]
4035
4136
> After installing, validate the version by running just `shopify` in your terminal.
@@ -44,6 +39,8 @@ jobs:
4439
4540
> Use `which shopify` to find out which one you are running and uninstall it."
4641
build_script: "pnpm nx run-many --target=bundle --all --skip-nx-cache --output-style=stream && pnpm refresh-manifests"
42+
package_manager: 'npm'
43+
shopify_registry: 'https://registry.npmjs.org'
4744
env:
4845
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
4946
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

packages/features/steps/github-actions.steps.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ When(/I look at the github actions we use/, async function () {
1414

1515
Then(/I see all non-official actions being pinned/, async function () {
1616
const remaining: string[] = this.githubActions.filter(
17-
// we skip the ones from github or from the repo
18-
(action: string) => !action.startsWith('actions/') && !action.startsWith('./'),
17+
// we skip the ones from github, from the repo or from Shopify
18+
(action: string) => !action.startsWith('actions/') && !action.startsWith('./') && !action.startsWith('Shopify/'),
1919
)
2020
const unpinned = remaining.filter(
2121
(action: string) =>

0 commit comments

Comments
 (0)