-
Notifications
You must be signed in to change notification settings - Fork 219
remove STDIN support on execute commands
#6734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove STDIN support on execute commands
#6734
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report
Test suite run success3567 tests passing in 1416 suites. Report generated by 🧪jest coverage report action from 6d211c7 |
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
execute commands
5489167 to
6d211c7
Compare
|
Just curious, what from the testing made you conclude that variables should be passable via STDIN, instead of queries? |
szluzero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great DX improvement!
Good question. The fact that I was using previous query results to drive mutations primarily. And realizing how damn powerful |

WHY are these changes introduced?
With the addition of
--query-file, we now have 3 ways of specifying the GraphQL query, which is a bit excessive. Reading queries fromSTDINis really only useful forechoorcat, and--queryand--query-filecover those cases respectively.Testing of these commands in scripts makes it apparent that if anything, variables should be passable via
STDIN. Let's hold off on that, but meanwhile let's reserveSTDINfor that possibility.WHAT is this pull request doing?
exclusiveflag constraint withexactlyOnefor query input flags to ensure users provide either--queryor--query-fileBugErrorwhen flag validation failsprepareExecuteContextfunction by removing the command name parameterHow to test your changes?
shopify app executewithout providing either--queryor--query-file--queryparameter--query-fileparameterMeasuring impact
How do we know this change was effective? Please choose one:
Checklist