-
Notifications
You must be signed in to change notification settings - Fork 224
update URLs in description for app generate extension #6742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kbav
wants to merge
1
commit into
main
Choose a base branch
from
kbav/update_urls_in_description_for_app_generate_extension
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
update URLs in description for app generate extension #6742
kbav
wants to merge
1
commit into
main
from
kbav/update_urls_in_description_for_app_generate_extension
+18
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3586 tests passing in 1420 suites. Report generated by 🧪jest coverage report action from 629835a |
5803d37 to
d28bf9c
Compare
d28bf9c to
213c8ef
Compare
Co-authored-by: Alvaro Gutierrez <[email protected]>, Co-authored-by: Pierre-Olivier Bédard <[email protected]>
213c8ef to
629835a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Note
This is my first PR for the
clirepo. Doing something small now to learn the local build + CI + PR + shipping process.WHY are these changes introduced?
Updates shopify.dev URLs found in the description for
shopify app generate extension.Each currently redirects OK, but this PR updates to the current accurate locations.
WHAT is this pull request doing?
Updates URLs
How to test your changes?
Build and run
shopify app generate extension --helpand confirm the URLs are accurate.Post-release steps
N/A
Measuring impact
How do we know this change was effective? Please choose one:
Checklist