Skip to content

Commit 0e15a2d

Browse files
committed
add some LFs and docblocks
1 parent c21ddf8 commit 0e15a2d

File tree

4 files changed

+37
-0
lines changed

4 files changed

+37
-0
lines changed

src/Draggable/Sensors/MouseSensor/MouseSensor.js

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,20 @@ export default class MouseSensor extends Sensor {
3232
*/
3333
this.mouseDownTimeout = null;
3434

35+
/**
36+
* Save pageX coordinates for delay drag
37+
* @property {Numbre} pageX
38+
* @private
39+
*/
40+
this.pageX = null;
41+
42+
/**
43+
* Save pageY coordinates for delay drag
44+
* @property {Numbre} pageY
45+
* @private
46+
*/
47+
this.pageY = null;
48+
3549
this[onContextMenuWhileDragging] = this[onContextMenuWhileDragging].bind(this);
3650
this[onMouseDown] = this[onMouseDown].bind(this);
3751
this[onMouseMove] = this[onMouseMove].bind(this);

src/Draggable/Sensors/MouseSensor/tests/MouseSensor.test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -275,6 +275,7 @@ describe('MouseSensor', () => {
275275
}
276276
expect(dragFlow).toHaveTriggeredSensorEvent('drag:start', 1);
277277
});
278+
278279
it('only triggers `drag:start` sensor event once when distance is met after delay', () => {
279280
function dragFlow() {
280281
clickMouse(draggableElement);

src/Draggable/Sensors/TouchSensor/TouchSensor.js

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,20 @@ export default class TouchSensor extends Sensor {
6565
*/
6666
this.touchMoved = false;
6767

68+
/**
69+
* Save pageX coordinates for delay drag
70+
* @property {Numbre} pageX
71+
* @private
72+
*/
73+
this.pageX = null;
74+
75+
/**
76+
* Save pageY coordinates for delay drag
77+
* @property {Numbre} pageY
78+
* @private
79+
*/
80+
this.pageY = null;
81+
6882
this[onTouchStart] = this[onTouchStart].bind(this);
6983
this[onTouchEnd] = this[onTouchEnd].bind(this);
7084
this[onTouchMove] = this[onTouchMove].bind(this);

src/Draggable/Sensors/TouchSensor/tests/TouchSensor.test.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,12 @@ describe('TouchSensor', () => {
2626
touchSensor.detach();
2727
sandbox.parentNode.removeChild(sandbox);
2828
}
29+
2930
describe('common', () => {
3031
beforeEach(setup);
32+
3133
afterEach(teardown);
34+
3235
it('cancels `drag:start` event when canceling sensor event', () => {
3336
sandbox.addEventListener('drag:start', (event) => {
3437
event.detail.cancel();
@@ -51,6 +54,7 @@ describe('TouchSensor', () => {
5154

5255
expect(dragFlow).not.toHaveTriggeredSensorEvent('drag:start');
5356
});
57+
5458
it('prevents context menu while dragging', () => {
5559
touchStart(draggableElement);
5660
let contextMenuEvent = triggerEvent(draggableElement, 'contextmenu');
@@ -94,12 +98,14 @@ describe('TouchSensor', () => {
9498
expect(touchEndEvent.defaultPrevented).toBe(true);
9599
});
96100
});
101+
97102
describe('using distance', () => {
98103
beforeEach(() => {
99104
setup({delay: 0, distance: 1});
100105
});
101106

102107
afterEach(teardown);
108+
103109
it('does not trigger `drag:start` before distance has been travelled', () => {
104110
function dragFlow() {
105111
touchStart(draggableElement);
@@ -153,6 +159,7 @@ describe('TouchSensor', () => {
153159
beforeEach(() => {
154160
setup({delay: DRAG_DELAY, distance: 0});
155161
});
162+
156163
afterEach(teardown);
157164

158165
it('does not trigger `drag:start` before delay ends', () => {
@@ -210,6 +217,7 @@ describe('TouchSensor', () => {
210217
beforeEach(() => {
211218
setup({delay: DRAG_DELAY, distance: 1});
212219
});
220+
213221
afterEach(teardown);
214222

215223
it('does not trigger `drag:start` before delay ends', () => {

0 commit comments

Comments
 (0)