Fixing linter warnings

tsov · tsov · commit 338170af3c09 · 2023-09-18T14:04:19.000-07:00
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -1,17 +1,15 @@
 module.exports = {
-  extends: [
-    'plugin:@shopify/esnext',
-    'plugin:@shopify/jest',
-    'plugin:@shopify/prettier',
-  ],
+  extends: ['plugin:@shopify/esnext', 'plugin:@shopify/jest', 'plugin:@shopify/prettier'],
   env: {
     browser: true,
+    node: true,
   },
   rules: {
     'import/no-unresolved': 'off',
     'import/no-extraneous-dependencies': 'off',
     'class-methods-use-this': 'off',
     'line-comment-position': 0,
     'lines-around-comment': 'off',
+    'jest/valid-title': 'off',
   },
 };
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -10,7 +10,9 @@
     "lib": true
   },
   "editor.formatOnSave": true,
-  "prettier.eslintIntegration": true,
+  "editor.codeActionsOnSave": {
+    "source.fixAll.eslint": true
+  },
   "javascript.validate.enable": false,
   "eslint.validate": ["javascript"]
 }
diff --git a/scripts/build.js b/scripts/build.js
@@ -1,4 +1,5 @@
 const webpack = require('webpack');
+
 const {isProd, useAnalyser} = require('./build/config');
 const {createConfig: createDevelopmentConfig} = require('./build/development');
 const {createConfig: createProductionConfig} = require('./build/production');
diff --git a/scripts/build/config.js b/scripts/build/config.js
@@ -1,5 +1,3 @@
-/* eslint-disable no-process-env */
-
 const args = process.argv.filter((value, index) => index >= 2);
 const useAnalyser = args.find((value) => value === '--analyser');
 const isProd = args.find((value) => value === '--production');
@@ -15,5 +13,3 @@ module.exports = {
   resolveModules,
   useAnalyser,
 };
-
-/* eslint-enable no-process-env */
diff --git a/scripts/build/development.js b/scripts/build/development.js
@@ -1,4 +1,5 @@
 const BundleAnalyzerPlugin = require('webpack-bundle-analyzer').BundleAnalyzerPlugin;
+
 const {targetPath, resolveModules} = require('./config');
 
 function createConfig({analyser}) {
diff --git a/scripts/build/production.js b/scripts/build/production.js
@@ -1,4 +1,5 @@
 const BundleAnalyzerPlugin = require('webpack-bundle-analyzer').BundleAnalyzerPlugin;
+
 const {targetPath, resolveModules} = require('./config');
 const {bundles} = require('./bundles');
 
diff --git a/scripts/test/environment.js b/scripts/test/environment.js
@@ -8,16 +8,16 @@ window.cancelAnimationFrame = (id) => {
   return clearTimeout(id);
 };
 
-Event.prototype.stopPropagation = (function(_super) {
-  return function(...args) {
+Event.prototype.stopPropagation = (function (_super) {
+  return function (...args) {
     const returnValue = _super.call(this, ...args);
     this.stoppedPropagation = true;
     return returnValue;
   };
 })(Event.prototype.stopPropagation);
 
-Event.prototype.stopImmediatePropagation = (function(_super) {
-  return function(...args) {
+Event.prototype.stopImmediatePropagation = (function (_super) {
+  return function (...args) {
     const returnValue = _super.call(this, ...args);
     this.stoppedPropagation = true;
     return returnValue;
diff --git a/scripts/test/helpers/event.js b/scripts/test/helpers/event.js
@@ -5,7 +5,7 @@ export function triggerEvent(element, type, data = {}) {
   event.initEvent(type, true, true);
 
   for (const key in data) {
-    if (data.hasOwnProperty(key)) {
+    if (Object.prototype.hasOwnProperty.call(data, key)) {
       Object.defineProperty(event, key, {
         value: data[key],
       });
diff --git a/scripts/test/helpers/plugin.js b/scripts/test/helpers/plugin.js
@@ -4,8 +4,8 @@ export class TestPlugin extends AbstractPlugin {
   constructor(draggable) {
     super(draggable);
 
-    this.attachFunction = jest.fn();
-    this.detachFunction = jest.fn();
+    jest.spyOn(this, 'attachFunction').mockImplementation();
+    jest.spyOn(this, 'detachFunction').mockImplementation();
   }
 
   attach() {
@@ -15,4 +15,9 @@ export class TestPlugin extends AbstractPlugin {
   detach() {
     this.detachFunction();
   }
+
+  /* eslint-disable no-empty-function */
+  attachFunction() {}
+  detachFunction() {}
+  /* eslint-enable no-empty-function */
 }
diff --git a/scripts/test/matchers/event.js b/scripts/test/matchers/event.js
@@ -6,7 +6,7 @@ function toHaveBeenCalledWithEvent(jestFunction, expectedEventConstructor) {
   let pass;
   let message;
 
-  // eslint-disable-next-line babel/no-invalid-this
+  // eslint-disable-next-line @babel/no-invalid-this
   pass = this.isNot && mockCalls.length === 0;
   if (pass) {
     message = () => `Expected ${expectedEventConstructor.type} event ${expectation(!pass)} triggered`;
diff --git a/scripts/test/setup.js b/scripts/test/setup.js
@@ -1,9 +1,11 @@
 import './matchers';
 
+/* eslint-disable jest/require-top-level-describe */
 beforeEach(() => {
   jest.useFakeTimers();
 });
 
 afterEach(() => {
   jest.runAllTimers();
 });
+/* eslint-enable jest/require-top-level-describe */
diff --git a/scripts/watch.js b/scripts/watch.js
@@ -1,4 +1,5 @@
 const webpack = require('webpack');
+
 const {createConfig: createDevelopmentConfig} = require('./build/development');
 const {runner} = require('./build/utils');
 
diff --git a/src/Draggable/Draggable.js b/src/Draggable/Draggable.js
@@ -1,11 +1,9 @@
 import {closest} from 'shared/utils';
 
 import {Announcement, Focusable, Mirror, Scrollable} from './Plugins';
-
 import Emitter from './Emitter';
 import {MouseSensor, TouchSensor} from './Sensors';
 import {DraggableInitializedEvent, DraggableDestroyEvent} from './DraggableEvent';
-
 import {
   DragStartEvent,
   DragMoveEvent,
diff --git a/src/Draggable/Emitter/Emitter.js b/src/Draggable/Emitter/Emitter.js
@@ -69,7 +69,7 @@ export default class Emitter {
     if (caughtErrors.length) {
       /* eslint-disable no-console */
       console.error(`Draggable caught errors while triggering '${event.type}'`, caughtErrors);
-      /* eslint-disable no-console */
+      /* eslint-enable no-console */
     }
 
     return this;
diff --git a/src/Draggable/Emitter/tests/Emitter.test.js b/src/Draggable/Emitter/tests/Emitter.test.js
@@ -1,4 +1,5 @@
 import AbstractEvent from 'shared/AbstractEvent';
+
 import Emitter from '../Emitter';
 
 class TestEvent extends AbstractEvent {}
@@ -24,8 +25,8 @@ describe('Emitter', () => {
 
       emitter.on('event', ...callbacks);
 
-      expect(emitter.callbacks.event[0]).toEqual(callbacks[0]);
-      expect(emitter.callbacks.event[1]).toEqual(callbacks[1]);
+      expect(emitter.callbacks.event[0]).toStrictEqual(callbacks[0]);
+      expect(emitter.callbacks.event[1]).toStrictEqual(callbacks[1]);
     });
   });
 
diff --git a/src/Draggable/Plugins/Focusable/tests/Focusable.test.js b/src/Draggable/Plugins/Focusable/tests/Focusable.test.js
@@ -1,4 +1,5 @@
 import {createSandbox, waitForRequestAnimationFrame} from 'helper';
+
 import Draggable from '../../..';
 import Focusable from '..';
 
@@ -50,7 +51,7 @@ describe('Focusable', () => {
     waitForRequestAnimationFrame();
 
     elements.forEach((element) => {
-      expect(element.tabIndex).toEqual(0);
+      expect(element.tabIndex).toBe(0);
     });
   });
 
@@ -68,7 +69,7 @@ describe('Focusable', () => {
     waitForRequestAnimationFrame();
 
     elements.forEach((element) => {
-      expect(element.tabIndex).toEqual(-1);
+      expect(element.tabIndex).toBe(-1);
     });
   });
 
@@ -85,7 +86,7 @@ describe('Focusable', () => {
 
     waitForRequestAnimationFrame();
 
-    expect(nativelyFocusableElement.tabIndex).toEqual(0);
+    expect(nativelyFocusableElement.tabIndex).toBe(0);
   });
 
   it('does not remove tabindex properties for element with tabindex attribute', () => {
@@ -102,6 +103,6 @@ describe('Focusable', () => {
 
     waitForRequestAnimationFrame();
 
-    expect(elementWithTabIndexAttribute.tabIndex).toEqual(originalTabIndex);
+    expect(elementWithTabIndexAttribute.tabIndex).toStrictEqual(originalTabIndex);
   });
 });
diff --git a/src/Draggable/Plugins/Mirror/tests/Mirror.test.js b/src/Draggable/Plugins/Mirror/tests/Mirror.test.js
@@ -17,7 +17,6 @@ import {
   MirrorMovedEvent,
   MirrorDestroyEvent,
 } from '../MirrorEvent';
-
 import Draggable from '../../..';
 
 const sampleMarkup = `
diff --git a/src/Draggable/Sensors/DragSensor/DragSensor.js b/src/Draggable/Sensors/DragSensor/DragSensor.js
@@ -1,4 +1,5 @@
 import {closest} from 'shared/utils';
+
 import Sensor from '../Sensor';
 import {DragStartSensorEvent, DragMoveSensorEvent, DragStopSensorEvent} from '../SensorEvent';
 
@@ -173,7 +174,6 @@ export default class DragSensor extends Sensor {
    * @param {Event} event - Drop event
    */
   [onDrop](event) {
-    // eslint-disable-line class-methods-use-this
     event.preventDefault();
   }
 
diff --git a/src/Draggable/Sensors/DragSensor/tests/DragSensor.test.js b/src/Draggable/Sensors/DragSensor/tests/DragSensor.test.js
@@ -51,6 +51,7 @@ describe('DragSensor', () => {
 
     afterEach(teardown);
 
+    /* eslint-disable jest/no-disabled-tests */
     it.skip('mousedown handler adds draggable attribute', () => {
       expect(draggableElement.draggable).toBeUndefined();
 
@@ -63,6 +64,7 @@ describe('DragSensor', () => {
 
       expect(draggableElement.draggable).toBe(false);
     });
+    /* eslint-enable jest/no-disabled-tests */
 
     it('triggers `drag:start` sensor event on dragstart', () => {
       function dragFlow() {
diff --git a/src/Draggable/Sensors/ForceTouchSensor/ForceTouchSensor.js b/src/Draggable/Sensors/ForceTouchSensor/ForceTouchSensor.js
@@ -1,4 +1,5 @@
 import {closest} from 'shared/utils';
+
 import Sensor from '../Sensor';
 import {DragStartSensorEvent, DragMoveSensorEvent, DragStopSensorEvent, DragPressureSensorEvent} from '../SensorEvent';
 
diff --git a/src/Draggable/Sensors/MouseSensor/MouseSensor.js b/src/Draggable/Sensors/MouseSensor/MouseSensor.js
@@ -1,4 +1,5 @@
 import {closest, distance as euclideanDistance} from 'shared/utils';
+
 import Sensor from '../Sensor';
 import {DragStartSensorEvent, DragMoveSensorEvent, DragStopSensorEvent} from '../SensorEvent';
 
diff --git a/src/Draggable/Sensors/MouseSensor/tests/MouseSensor.test.js b/src/Draggable/Sensors/MouseSensor/tests/MouseSensor.test.js
@@ -1,4 +1,5 @@
 import {createSandbox, triggerEvent, waitForDragDelay, DRAG_DELAY, clickMouse, moveMouse, releaseMouse} from 'helper';
+
 import MouseSensor from '..';
 
 const sampleMarkup = `
diff --git a/src/Draggable/Sensors/Sensor/Sensor.js b/src/Draggable/Sensors/Sensor/Sensor.js
@@ -1,4 +1,4 @@
-const defaultDealy = {
+const defaultDelay = {
   mouse: 0,
   drag: 0,
   touch: 100,
@@ -126,22 +126,22 @@ function calcDelay(optionsDelay) {
   const delay = {};
 
   if (optionsDelay === undefined) {
-    return {...defaultDealy};
+    return {...defaultDelay};
   }
 
   if (typeof optionsDelay === 'number') {
-    for (const key in defaultDealy) {
-      if (defaultDealy.hasOwnProperty(key)) {
+    for (const key in defaultDelay) {
+      if (Object.prototype.hasOwnProperty.call(defaultDelay, key)) {
         delay[key] = optionsDelay;
       }
     }
     return delay;
   }
 
-  for (const key in defaultDealy) {
-    if (defaultDealy.hasOwnProperty(key)) {
+  for (const key in defaultDelay) {
+    if (Object.prototype.hasOwnProperty.call(defaultDelay, key)) {
       if (optionsDelay[key] === undefined) {
-        delay[key] = defaultDealy[key];
+        delay[key] = defaultDelay[key];
       } else {
         delay[key] = optionsDelay[key];
       }
diff --git a/src/Draggable/Sensors/Sensor/tests/Sensor.test.js b/src/Draggable/Sensors/Sensor/tests/Sensor.test.js
@@ -14,15 +14,15 @@ describe('Sensor', () => {
       const expectedOptions = {expectedOptions: true};
       const sensor = new Sensor(expectedContainers, expectedOptions);
 
-      expect(sensor.containers).toEqual(expectedContainers);
-      expect(sensor.options).toEqual(expectedOptions);
+      expect(sensor.containers).toStrictEqual(expectedContainers);
+      expect(sensor.options).toStrictEqual(expectedOptions);
     });
 
     describe('should initialize with correct delay', () => {
       it('unset', () => {
         const sensor = new Sensor(undefined, {});
 
-        expect(sensor.delay).toEqual({
+        expect(sensor.delay).toStrictEqual({
           mouse: 0,
           drag: 0,
           touch: 100,
@@ -32,7 +32,7 @@ describe('Sensor', () => {
       it('number', () => {
         const sensor = new Sensor(undefined, {delay: 42});
 
-        expect(sensor.delay).toEqual({
+        expect(sensor.delay).toStrictEqual({
           mouse: 42,
           drag: 42,
           touch: 42,
@@ -42,7 +42,7 @@ describe('Sensor', () => {
       it('object', () => {
         const sensor = new Sensor(undefined, {delay: {mouse: 42, drag: 142}});
 
-        expect(sensor.delay).toEqual({
+        expect(sensor.delay).toStrictEqual({
           mouse: 42,
           drag: 142,
           touch: 100,
@@ -74,11 +74,11 @@ describe('Sensor', () => {
       const containers = [document.documentElement, document.body];
       const sensor = new Sensor();
 
-      expect(sensor.containers).toEqual([]);
+      expect(sensor.containers).toStrictEqual([]);
 
       sensor.addContainer(...containers);
 
-      expect(sensor.containers).toEqual(containers);
+      expect(sensor.containers).toStrictEqual(containers);
     });
   });
 
@@ -87,11 +87,11 @@ describe('Sensor', () => {
       const containers = [document.documentElement, document.body];
       const sensor = new Sensor(containers);
 
-      expect(sensor.containers).toEqual(containers);
+      expect(sensor.containers).toStrictEqual(containers);
 
       sensor.removeContainer(...containers);
 
-      expect(sensor.containers).toEqual([]);
+      expect(sensor.containers).toStrictEqual([]);
     });
   });
 
diff --git a/src/Draggable/Sensors/TouchSensor/TouchSensor.js b/src/Draggable/Sensors/TouchSensor/TouchSensor.js
@@ -1,4 +1,5 @@
 import {closest, distance as euclideanDistance, touchCoords} from 'shared/utils';
+
 import Sensor from '../Sensor';
 import {DragStartSensorEvent, DragMoveSensorEvent, DragStopSensorEvent} from '../SensorEvent';
 
diff --git a/src/Draggable/tests/Draggable.test.js b/src/Draggable/tests/Draggable.test.js
diff --git a/src/Droppable/Droppable.js b/src/Droppable/Droppable.js
diff --git a/src/Plugins/Collidable/Collidable.js b/src/Plugins/Collidable/Collidable.js
diff --git a/src/Plugins/ResizeMirror/tests/ResizeMirror.test.js b/src/Plugins/ResizeMirror/tests/ResizeMirror.test.js
diff --git a/src/Plugins/Snappable/Snappable.js b/src/Plugins/Snappable/Snappable.js
diff --git a/src/Sortable/Sortable.js b/src/Sortable/Sortable.js
diff --git a/src/Sortable/tests/Sortable.test.js b/src/Sortable/tests/Sortable.test.js
diff --git a/src/Swappable/Swappable.js b/src/Swappable/Swappable.js
diff --git a/src/Swappable/tests/Swappable.test.js b/src/Swappable/tests/Swappable.test.js
diff --git a/src/index.legacy.js b/src/index.legacy.js
diff --git a/src/shared/utils/closest/tests/closest.test.js b/src/shared/utils/closest/tests/closest.test.js
diff --git a/src/tests/bundle.test.js b/src/tests/bundle.test.js

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`const webpack = require('webpack');`
	`2`	`+`
`2`	`3`	`const {isProd, useAnalyser} = require('./build/config');`
`3`	`4`	`const {createConfig: createDevelopmentConfig} = require('./build/development');`
`4`	`5`	`const {createConfig: createProductionConfig} = require('./build/production');`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`const BundleAnalyzerPlugin = require('webpack-bundle-analyzer').BundleAnalyzerPlugin;`
	`2`	`+`
`2`	`3`	`const {targetPath, resolveModules} = require('./config');`
`3`	`4`
`4`	`5`	`function createConfig({analyser}) {`
Original file line number	Diff line number	Diff line change
`@@ -4,8 +4,8 @@ export class TestPlugin extends AbstractPlugin {`
`4`	`4`	`constructor(draggable) {`
`5`	`5`	`super(draggable);`
`6`	`6`
`7`		`- this.attachFunction = jest.fn();`
`8`		`- this.detachFunction = jest.fn();`
	`7`	`+ jest.spyOn(this, 'attachFunction').mockImplementation();`
	`8`	`+ jest.spyOn(this, 'detachFunction').mockImplementation();`
`9`	`9`	`}`
`10`	`10`
`11`	`11`	`attach() {`
`@@ -15,4 +15,9 @@ export class TestPlugin extends AbstractPlugin {`
`15`	`15`	`detach() {`
`16`	`16`	`this.detachFunction();`
`17`	`17`	`}`
	`18`	`+`
	`19`	`+ /* eslint-disable no-empty-function */`
	`20`	`+ attachFunction() {}`
	`21`	`+ detachFunction() {}`
	`22`	`+ /* eslint-enable no-empty-function */`
`18`	`23`	`}`