🎨 [JS] Fix linting

Author: beefchimi

examples/.eslintrc.js

@@ -1,10 +1,11 @@
+/* eslint-env node */
 module.exports = {
   extends: ['plugin:shopify/esnext', 'plugin:shopify/webpack', 'plugin:shopify/prettier'],
   globals: {},
   rules: {
     'shopify/jsx-no-complex-expressions': 'off',
     'eslint-comments/no-unlimited-disable': 0,
-    'import/no-default-export': ['error'],
+    // 'import/no-default-export': ['error'],
     'lines-around-comment': [
       'error',
       {
@@ -16,11 +17,13 @@ module.exports = {
     'no-negated-condition': 'off',
     // We are intentionally keeping `TODO` comments until a stable release
     'no-warning-comments': 'off',
+    'import/no-cycle': 'off',
     // TODO: Disabling for now, but we will want to re-enable in the future.
     'import/no-default-export': 'off',
-    'import/no-cycle': 'off',
   },
   env: {
     browser: true,
   },
+  // Required, else eslint will look at the parent config
+  root: true,
 };

examples/src/components/Plate/index.js

@@ -16,7 +16,7 @@ function calculatePlateScale(value, max, factor) {
   const step1 = Math.abs(value) / max;
   const step2 = step1 - step1 * factor;
 
-  return 1 - step2; // step 3
+  return 1 - step2;
 }
 
 export default class Plate {
@@ -89,6 +89,7 @@ export default class Plate {
 
   _translateEachPlate(x, y) {
     for (const plateLevel in this.plates) {
+      // eslint-disable-next-line no-prototype-builtins
       if (this.plates.hasOwnProperty(plateLevel)) {
         const translateX = flipSign(x * 2) * translateFactors[plateLevel];
         const translateY = flipSign(y * 2) * translateFactors[plateLevel];

examples/src/content/Home/index.js

@@ -1,5 +1,7 @@
 // eslint-disable-next-line import/no-unresolved
 import {Draggable} from '@shopify/draggable';
+
+// eslint-disable-next-line shopify/strict-component-boundaries
 import Plate from '../../components/Plate';
 
 export default function Home() {

examples/src/content/Sortable/MultipleContainers/index.js

@@ -29,7 +29,8 @@ export default function MultipleContainers() {
 
   // --- Draggable events --- //
   sortable.on('drag:start', (evt) => {
-    currentMediumChildren = sortable.getDraggableElementsForContainer(sortable.containers[1]).length;
+    currentMediumChildren = sortable.getDraggableElementsForContainer(sortable.containers[1])
+      .length;
     capacityReached = currentMediumChildren === containerTwoCapacity;
     lastOverContainer = evt.sourceContainer;
     containerTwoParent.classList.toggle(Classes.capacity, capacityReached);

examples/src/scripts/examples-app.js

@@ -1,4 +1,6 @@
+// eslint-disable-next-line shopify/strict-component-boundaries
 import Analytics from '../components/Analytics';
+// eslint-disable-next-line shopify/strict-component-boundaries
 import MobileNav from '../components/MobileNav';
 import Content from '../content';
 
@@ -12,6 +14,7 @@ mobileNav.init();
 
 // Initialize all examples
 for (const Example in Content) {
+  // eslint-disable-next-line no-prototype-builtins
   if (Content.hasOwnProperty(Example)) {
     Content[Example]();
   }

examples/src/scripts/utils/debounce.js

@@ -1,7 +1,7 @@
 export default function debounce(callback, wait) {
   let timeout = null;
 
-  return function(...args) {
+  return function (...args) {
     const context = this; // eslint-disable-line consistent-this, babel/no-invalid-this
 
     clearTimeout(timeout);

examples/tools/index.js

@@ -1,4 +1,5 @@
 import gulp from 'gulp';
+
 import tasks from './tasks';
 import {watch} from './watch';
 

examples/tools/tasks/index.js

@@ -1,4 +1,5 @@
 import {startServer} from '../server';
+
 import {scripts} from './scripts';
 import {styles} from './styles';
 import {views} from './views';

examples/tools/tasks/scripts.js

@@ -1,4 +1,5 @@
 import webpack from 'webpack';
+
 import {webpackConfig} from '../webpack.config';
 
 export function scripts() {

examples/tools/tasks/styles.js

@@ -2,6 +2,7 @@ import gulp from 'gulp';
 import sass from 'gulp-sass';
 import postcss from 'gulp-postcss';
 import sourcemaps from 'gulp-sourcemaps';
+
 import {server} from '../server';
 
 export const srcStyles = 'src/styles/';