Skip to content

Commit 9154a96

Browse files
committed
Converts SensorEvent to typescript
1 parent 527dcb6 commit 9154a96

File tree

6 files changed

+23
-6
lines changed

6 files changed

+23
-6
lines changed

.changeset/curvy-pots-whisper.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@shopify/draggable': patch
3+
---
4+
5+
Convert SensorEvent to typescript

src/Draggable/DragEvent/DragEvent.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import AbstractEvent from 'shared/AbstractEvent';
2-
import {FixMeAny} from 'shared/types';
2+
3+
import {SensorEvent} from '../Sensors/SensorEvent';
34

45
/**
56
* DragEventData
@@ -10,7 +11,7 @@ export interface DragEventData {
1011
originalSource: HTMLElement;
1112
mirror: HTMLElement;
1213
sourceContainer: HTMLElement;
13-
sensorEvent: FixMeAny;
14+
sensorEvent: SensorEvent;
1415
}
1516

1617
/**

src/Draggable/Plugins/Mirror/MirrorEvent/MirrorEvent.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
import AbstractEvent from 'shared/AbstractEvent';
2-
import {FixMeAny} from 'shared/types';
32

43
import {DragEvent, DragEventData} from '../../../DragEvent';
4+
import {SensorEvent} from '../../../Sensors/SensorEvent';
55

66
interface MirrorEventData {
77
source: HTMLElement;
88
originalSource: HTMLElement;
99
sourceContainer: HTMLElement;
10-
sensorEvent: FixMeAny;
10+
sensorEvent: SensorEvent;
1111
dragEvent: DragEvent<DragEventData>;
1212
}
1313

src/Draggable/Sensors/SensorEvent/SensorEvent.js renamed to src/Draggable/Sensors/SensorEvent/SensorEvent.ts

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,22 @@
11
import AbstractEvent from 'shared/AbstractEvent';
22

3+
interface SensorEventData {
4+
originalEvent: Event;
5+
clientX: number;
6+
clientY: number;
7+
target: HTMLElement;
8+
container: HTMLElement;
9+
originalSource: HTMLElement;
10+
pressure?: number;
11+
}
12+
313
/**
414
* Base sensor event
515
* @class SensorEvent
616
* @module SensorEvent
717
* @extends AbstractEvent
818
*/
9-
export class SensorEvent extends AbstractEvent {
19+
export class SensorEvent extends AbstractEvent<SensorEventData> {
1020
/**
1121
* Original browser event that triggered a sensor
1222
* @property originalEvent

src/Plugins/ResizeMirror/ResizeMirror.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import AbstractPlugin from 'shared/AbstractPlugin';
22
import {requestNextAnimationFrame} from 'shared/utils';
33
import {FixMeAny} from 'shared/types';
44

5+
import {MirrorCreatedEvent} from '../../Draggable/Plugins/Mirror/MirrorEvent';
56
import {
67
DragOverEvent,
78
DragOverContainerEvent,
@@ -92,7 +93,7 @@ export default class ResizeMirror extends AbstractPlugin {
9293
* @param {MirrorCreatedEvent} mirrorEvent
9394
* @private
9495
*/
95-
private onMirrorCreated({mirror}: FixMeAny) {
96+
private onMirrorCreated({mirror}: MirrorCreatedEvent) {
9697
this.mirror = mirror;
9798
}
9899

0 commit comments

Comments
 (0)