Merge pull request #568 from Shopify/housekeeping

Housekeeping

Author: tsov

.circleci/config.yml

@@ -1,17 +1,15 @@
 module.exports = {
-  extends: [
-    'plugin:shopify/esnext',
-    'plugin:shopify/jest',
-    'plugin:shopify/prettier',
-  ],
+  extends: ['plugin:@shopify/esnext', 'plugin:@shopify/jest', 'plugin:@shopify/prettier'],
   env: {
     browser: true,
+    node: true,
   },
   rules: {
     'import/no-unresolved': 'off',
     'import/no-extraneous-dependencies': 'off',
     'class-methods-use-this': 'off',
     'line-comment-position': 0,
     'lines-around-comment': 'off',
+    'jest/valid-title': 'off',
   },
 };

.eslintrc.js

@@ -1,12 +1,12 @@
-> Thank you for submitting a pull request! Please make sure you have read the [contribution guidelines](https://github.com/Shopify/draggable/blob/master/CONTRIBUTING.md) before proceeding.
+<!-- Thank you for submitting a pull request! Please make sure you have read the [contribution guidelines](https://github.com/Shopify/draggable/blob/master/CONTRIBUTING.md) before proceeding. -->
 
-### This PR implements or fixes... _(explain your changes)_
+### This PR implements or fixes...
 
-…
+<!-- Explain your changes -->
 
-### This PR closes the following issues... _(if applicable)_
+### This PR closes the following issues...
 
-…
+<!-- If applicable -->
 
 ### Does this PR require the Docs to be updated?
 
@@ -20,9 +20,9 @@
 
 **Browsers:**
 
-* [ ] Chrome _version_
-* [ ] Firefox _version_
-* [ ] Safari _version_
-* [ ] IE / Edge _version_
-* [ ] iOS Browser _version_
-* [ ] Android Browser _version_
+- [ ] Chrome _version_
+- [ ] Firefox _version_
+- [ ] Safari _version_
+- [ ] IE / Edge _version_
+- [ ] iOS Browser _version_
+- [ ] Android Browser _version_

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,29 @@
+name: CI
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout branch
+        uses: actions/checkout@v3
+        with:
+          fetch-depth: 2
+
+      - uses: actions/setup-node@v3
+        with:
+          node-version: '18.17.1'
+
+      - name: Install dependencies
+        run: yarn --frozen-lockfile
+
+      - name: Lint
+        run: yarn lint
+
+      - name: Test
+        run: yarn test

.github/workflows/tests.yml

@@ -1 +1 @@
-v10.4.0
+v18.17.1

.nvmrc

@@ -10,7 +10,9 @@
     "lib": true
   },
   "editor.formatOnSave": true,
-  "prettier.eslintIntegration": true,
+  "editor.codeActionsOnSave": {
+    "source.fixAll.eslint": true
+  },
   "javascript.validate.enable": false,
   "eslint.validate": ["javascript"]
 }

.vscode/settings.json

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2018 Shopify
+Copyright (c) 2018-present Shopify
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

LICENSE.md

@@ -1,4 +1,3 @@
-[![CircleCI](https://circleci.com/gh/Shopify/draggable/tree/master.svg?style=shield)](https://circleci.com/gh/Shopify/draggable/tree/master)
 [![npm version](https://badge.fury.io/js/%40shopify%2Fdraggable.svg)](https://badge.fury.io/js/%40shopify%2Fdraggable)
 [![codecov](https://codecov.io/gh/Shopify/draggable/branch/master/graph/badge.svg)](https://codecov.io/gh/Shopify/draggable)
 [![Greenkeeper badge](https://badges.greenkeeper.io/Shopify/draggable.svg)](https://greenkeeper.io/)
@@ -11,7 +10,7 @@
 
 **Draggable is no longer maintained by its original authors.** Maintenance of this repo has been passed on to new collaborators and is no longer worked on by anyone at Shopify.
 
-**We are still looking for more maintainers!** If anyone is interested in answering / triaging issues, reviewing / rejecting / approving PRs, and authoring code for bug fixes / new features — please send an email to `curtis.dulmage (at) shopify (dot) com`. You may be asked a few questions before obtaining collaboration permission, but if everything checks out, we will happily add you as a collaborator.
+**We are still looking for more maintainers!** If anyone is interested in answering / triaging issues, reviewing / rejecting / approving PRs, and authoring code for bug fixes / new features — please send an email to `max.hoffmann (at) shopify (dot) com`. You may be asked a few questions before obtaining collaboration permission, but if everything checks out, we will happily add you as a collaborator.
 
 ---
 

README.md

@@ -1,7 +1,8 @@
 {
+  "testEnvironment": "jsdom",
   "testMatch": ["<rootDir>/src/**/*.test.js"],
   "setupFiles": ["<rootDir>/scripts/test/environment.js"],
-  "setupTestFrameworkScriptFile": "<rootDir>/scripts/test/setup.js",
+  "setupFilesAfterEnv": ["<rootDir>/scripts/test/setup.js"],
   "transform": {".*": "<rootDir>/node_modules/babel-jest"},
   "moduleFileExtensions": ["js"],
   "collectCoverageFrom": [

config.json

@@ -1 +1 @@
-v12.16.0
+v18.17.1