Skip to content

Commit eda2cca

Browse files
committed
dont appends mirror when mirror was removed
1 parent ad81954 commit eda2cca

File tree

2 files changed

+17
-0
lines changed

2 files changed

+17
-0
lines changed

src/Plugins/ResizeMirror/ResizeMirror.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,10 @@ export default class ResizeMirror extends AbstractPlugin {
126126
*/
127127
[resize]({overContainer, over}) {
128128
requestAnimationFrame(() => {
129+
if (!this.mirror.parentNode) {
130+
return;
131+
}
132+
129133
if (this.mirror.parentNode !== overContainer) {
130134
overContainer.appendChild(this.mirror);
131135
}

src/Plugins/ResizeMirror/tests/ResizeMirror.test.js

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import {
77
waitForDragDelay,
88
waitForPromisesToResolve,
99
DRAG_DELAY,
10+
drag,
1011
} from 'helper';
1112
import {Draggable} from '../../..';
1213
import ResizeMirror from '..';
@@ -129,6 +130,18 @@ describe('ResizeMirror', () => {
129130

130131
releaseMouse(largerDraggable);
131132
});
133+
134+
it('dont appends mirror when mirror was removed', async () => {
135+
drag({from: smallerDraggable, to: smallerDraggable});
136+
drag({from: smallerDraggable, to: smallerDraggable});
137+
138+
await waitForPromisesToResolve();
139+
waitForRequestAnimationFrame();
140+
141+
const mirror = document.querySelector('.draggable-mirror');
142+
143+
expect(mirror).toBeNull();
144+
});
132145
});
133146

134147
function mockDimensions(element, {width = 0, height = 0}) {

0 commit comments

Comments
 (0)