add better logs for discount (multi target)

lopert · lopert · commit 0c1a2107670d · 2025-11-06T11:41:48.000-05:00
diff --git a/functions-discount-js/tests/fixtures/cart-lines-discount-generate-log.json b/functions-discount-js/tests/fixtures/cart-lines-discount-generate-log.json
@@ -6,19 +6,20 @@
       "cart": {
         "lines": [
           {
-            "id": "gid://shopify/CartLine/1",
+            "id": "gid://shopify/CartLine/0",
             "cost": {
               "subtotalAmount": {
-                "amount": "100.0"
+                "amount": "6.0"
               }
             }
           }
         ]
       },
       "discount": {
-        "discountClasses": ["ORDER", "PRODUCT"]
+        "discountClasses": ["PRODUCT", "ORDER", "SHIPPING"]
       }
     },
+    "inputBytes": 126,
     "output": {
       "operations": [
         {
@@ -35,7 +36,7 @@
                 ],
                 "value": {
                   "percentage": {
-                    "value": 10
+                    "value": 10.0
                   }
                 }
               }
@@ -51,13 +52,13 @@
                 "targets": [
                   {
                     "cartLine": {
-                      "id": "gid://shopify/CartLine/1"
+                      "id": "gid://shopify/CartLine/0"
                     }
                   }
                 ],
                 "value": {
                   "percentage": {
-                    "value": 20
+                    "value": 20.0
                   }
                 }
               }
diff --git a/functions-discount-js/tests/fixtures/delivery-options-discount-generate-log.json b/functions-discount-js/tests/fixtures/delivery-options-discount-generate-log.json
@@ -0,0 +1,44 @@
+{
+  "payload": {
+    "export": "cart-delivery-options-discounts-generate-run",
+    "target": "cart.delivery-options.discounts.generate.run",
+    "input": {
+      "discount": {
+        "discountClasses": ["SHIPPING"]
+      },
+      "cart": {
+        "deliveryGroups": [
+          {
+            "id": "gid://shopify/CartDeliveryGroup/1"
+          }
+        ]
+      }
+    },
+    "output": {
+      "operations": [
+        {
+          "deliveryDiscountsAdd": {
+            "candidates": [
+              {
+                "message": "FREE DELIVERY",
+                "targets": [
+                  {
+                    "deliveryGroup": {
+                      "id": "gid://shopify/CartDeliveryGroup/1"
+                    }
+                  }
+                ],
+                "value": {
+                  "percentage": {
+                    "value": 100.0
+                  }
+                }
+              }
+            ],
+            "selectionStrategy": "ALL"
+          }
+        }
+      ]
+    }
+  }
+}
diff --git a/functions-discount-rs/tests/fixtures/cart-lines-discount-generate-log.json b/functions-discount-rs/tests/fixtures/cart-lines-discount-generate-log.json
@@ -6,19 +6,20 @@
       "cart": {
         "lines": [
           {
-            "id": "gid://shopify/CartLine/1",
+            "id": "gid://shopify/CartLine/0",
             "cost": {
               "subtotalAmount": {
-                "amount": "100.0"
+                "amount": "6.0"
               }
             }
           }
         ]
       },
       "discount": {
-        "discountClasses": ["ORDER", "PRODUCT"]
+        "discountClasses": ["PRODUCT", "ORDER", "SHIPPING"]
       }
     },
+    "inputBytes": 126,
     "output": {
       "operations": [
         {
@@ -54,7 +55,7 @@
                 "targets": [
                   {
                     "cartLine": {
-                      "id": "gid://shopify/CartLine/1",
+                      "id": "gid://shopify/CartLine/0",
                       "quantity": null
                     }
                   }
diff --git a/functions-discount-rs/tests/fixtures/delivery-options-discount-generate-log.json b/functions-discount-rs/tests/fixtures/delivery-options-discount-generate-log.json
@@ -0,0 +1,45 @@
+{
+  "payload": {
+    "export": "cart_delivery_options_discounts_generate_run",
+    "target": "cart.delivery-options.discounts.generate.run",
+    "input": {
+      "discount": {
+        "discountClasses": ["SHIPPING"]
+      },
+      "cart": {
+        "deliveryGroups": [
+           {
+             "id": "gid://shopify/CartDeliveryGroup/1"
+           }
+        ]
+      }
+    },
+    "output": {
+      "operations": [
+        {
+          "deliveryDiscountsAdd": {
+            "candidates": [
+              {
+                "associatedDiscountCode": null,
+                "message": "FREE DELIVERY",
+                "targets": [
+                  {
+                    "deliveryGroup": {
+                      "id": "gid://shopify/CartDeliveryGroup/1"
+                    }
+                  }
+                ],
+                "value": {
+                  "percentage": {
+                    "value": "100.0"
+                  }
+                }
+              }
+            ],
+            "selectionStrategy": "ALL"
+          }
+        }
+      ]
+    }
+  }
+}

Original file line number	Diff line number	Diff line change
`@@ -6,19 +6,20 @@`
`6`	`6`	`"cart": {`
`7`	`7`	`"lines": [`
`8`	`8`	`{`
`9`		`- "id": "gid://shopify/CartLine/1",`
	`9`	`+ "id": "gid://shopify/CartLine/0",`
`10`	`10`	`"cost": {`
`11`	`11`	`"subtotalAmount": {`
`12`		`- "amount": "100.0"`
	`12`	`+ "amount": "6.0"`
`13`	`13`	`}`
`14`	`14`	`}`
`15`	`15`	`}`
`16`	`16`	`]`
`17`	`17`	`},`
`18`	`18`	`"discount": {`
`19`		`- "discountClasses": ["ORDER", "PRODUCT"]`
	`19`	`+ "discountClasses": ["PRODUCT", "ORDER", "SHIPPING"]`
`20`	`20`	`}`
`21`	`21`	`},`
	`22`	`+ "inputBytes": 126,`
`22`	`23`	`"output": {`
`23`	`24`	`"operations": [`
`24`	`25`	`{`
`@@ -35,7 +36,7 @@`
`35`	`36`	`],`
`36`	`37`	`"value": {`
`37`	`38`	`"percentage": {`
`38`		`- "value": 10`
	`39`	`+ "value": 10.0`
`39`	`40`	`}`
`40`	`41`	`}`
`41`	`42`	`}`
`@@ -51,13 +52,13 @@`
`51`	`52`	`"targets": [`
`52`	`53`	`{`
`53`	`54`	`"cartLine": {`
`54`		`- "id": "gid://shopify/CartLine/1"`
	`55`	`+ "id": "gid://shopify/CartLine/0"`
`55`	`56`	`}`
`56`	`57`	`}`
`57`	`58`	`],`
`58`	`59`	`"value": {`
`59`	`60`	`"percentage": {`
`60`		`- "value": 20`
	`61`	`+ "value": 20.0`
`61`	`62`	`}`
`62`	`63`	`}`
`63`	`64`	`}`