Skip to content

Commit f9c635a

Browse files
naqvitalhanaqvitalha
committed
remove recyclerlistview
1 parent 137d9b9 commit f9c635a

File tree

8 files changed

+25
-164
lines changed

8 files changed

+25
-164
lines changed

‎fixture/react-native/yarn.lock

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -5643,7 +5643,7 @@ locate-path@^6.0.0:
56435643
dependencies:
56445644
p-locate "^5.0.0"
56455645

5646-
lodash.debounce@4.0.8, lodash.debounce@^4.0.8:
5646+
lodash.debounce@^4.0.8:
56475647
version "4.0.8"
56485648
resolved "https://registry.yarnpkg.com/lodash.debounce/-/lodash.debounce-4.0.8.tgz#82d79bff30a67c4005ffd5e2515300ad9ca4d7af"
56495649
integrity sha1-gteb/zCmfEAF/9XiUVMArZyk168=
@@ -6602,7 +6602,7 @@ prompts@^2.0.1, prompts@^2.4.2:
66026602
kleur "^3.0.3"
66036603
sisteransi "^1.0.5"
66046604

6605-
prop-types@15.8.1, prop-types@^15.8.1:
6605+
prop-types@^15.8.1:
66066606
version "15.8.1"
66076607
resolved "https://registry.yarnpkg.com/prop-types/-/prop-types-15.8.1.tgz#67d87bf1a694f48435cf332c24af10214a3140b5"
66086608
integrity sha512-oj87CgZICdulUohogVAR7AjlC0327U4el4L6eAvOqCeudMDVU0NThNaV+b9Df4dXgSP1gXMTnPdhfe/2qDH5cg==
@@ -6840,15 +6840,6 @@ readable-stream@^3.6.2:
68406840
string_decoder "^1.1.1"
68416841
util-deprecate "^1.0.1"
68426842

6843-
[email protected]:
6844-
version "4.2.3"
6845-
resolved "https://registry.yarnpkg.com/recyclerlistview/-/recyclerlistview-4.2.3.tgz#14032e7ad2f24396e24d5b3060c6ba76b567f000"
6846-
integrity sha512-STR/wj/FyT8EMsBzzhZ1l2goYirMkIgfV3gYEPxI3Kf3lOnu6f7Dryhyw7/IkQrgX5xtTcDrZMqytvteH9rL3g==
6847-
dependencies:
6848-
lodash.debounce "4.0.8"
6849-
prop-types "15.8.1"
6850-
ts-object-utils "0.0.5"
6851-
68526843
reflect.getprototypeof@^1.0.6, reflect.getprototypeof@^1.0.9:
68536844
version "1.0.10"
68546845
resolved "https://registry.yarnpkg.com/reflect.getprototypeof/-/reflect.getprototypeof-1.0.10.tgz#c629219e78a3316d8b604c765ef68996964e7bf9"
@@ -7711,16 +7702,6 @@ ts-api-utils@^1.3.0:
77117702
resolved "https://registry.yarnpkg.com/ts-api-utils/-/ts-api-utils-1.4.3.tgz#bfc2215fe6528fecab2b0fba570a2e8a4263b064"
77127703
integrity sha512-i3eMG77UTMD0hZhgRS562pv83RC6ukSAC2GMNWc+9dieh/+jDM5u5YG+NHX6VNDRHQcHwmsTHctP9LhbC3WxVw==
77137704

7714-
[email protected]:
7715-
version "0.0.5"
7716-
resolved "https://registry.yarnpkg.com/ts-object-utils/-/ts-object-utils-0.0.5.tgz#95361cdecd7e52167cfc5e634c76345e90a26077"
7717-
integrity sha1-lTYc3s1+UhZ8/F5jTHY0XpCiYHc=
7718-
7719-
[email protected]:
7720-
version "2.8.1"
7721-
resolved "https://registry.yarnpkg.com/tslib/-/tslib-2.8.1.tgz#612efe4ed235d567e8aba5f2a5fab70280ade83f"
7722-
integrity sha512-oJFu94HQb+KVduSUQL7wnpmqnfmLsOA/nAh6b6EH0wCEoK0/mPeXU6c3wKDV83MkOuHPRHtSXKKU99IBazS/2w==
7723-
77247705
tslib@^1.8.1:
77257706
version "1.14.1"
77267707
resolved "https://registry.yarnpkg.com/tslib/-/tslib-1.14.1.tgz#cf2d38bdc34a134bcaf1091c41f6619e2f672d00"

‎package.json

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"main": "dist/index.js",
2929
"types": "dist/index.d.ts",
3030
"scripts": {
31-
"up": "bundle install && yarn fixture:rn:up && yarn e2e:up && yarn build",
31+
"up": "yarn && yarn fixture:rn:up && yarn e2e:up && yarn build",
3232
"start": "cd fixture/react-native && react-native start",
3333
"test": "jest",
3434
"lint": "yarn eslint . --ext .ts,.tsx",
@@ -86,13 +86,5 @@
8686
"src",
8787
"jestSetup.js"
8888
],
89-
"dependencies": {
90-
"recyclerlistview": "4.2.3",
91-
"tslib": "2.8.1"
92-
},
93-
"codegenConfig": {
94-
"name": "rnflashlist",
95-
"type": "components",
96-
"jsSrcsDir": "./src/specs"
97-
}
89+
"dependencies": {}
9890
}

‎src/__tests__/ViewabilityHelper.test.ts

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1-
import { Dimension, Layout } from "recyclerlistview";
2-
31
import ViewabilityHelper from "../recyclerview/viewability/ViewabilityHelper";
42
import { ErrorMessages } from "../errors/ErrorMessages";
3+
import {
4+
RVDimension,
5+
RVLayout,
6+
} from "../recyclerview/layout-managers/LayoutManager";
57

68
describe("ViewabilityHelper", () => {
79
const viewableIndicesChanged = jest.fn();
@@ -60,7 +62,7 @@ describe("ViewabilityHelper", () => {
6062
);
6163
viewabilityHelper.possiblyViewableIndices = [0, 1, 2, 3];
6264
const getLayout = (index: number) => {
63-
return { x: index * 100, y: 0, height: 300, width: 100 } as Layout;
65+
return { x: index * 100, y: 0, height: 300, width: 100 } as RVLayout;
6466
};
6567
updateViewableItems({ viewabilityHelper, horizontal: true, getLayout });
6668
expect(viewableIndicesChanged).toHaveBeenCalledWith(
@@ -159,9 +161,9 @@ describe("ViewabilityHelper", () => {
159161
it("reports items that only satisfy viewAreaCoveragePercentThreshold", () => {
160162
const getLayout = (index: number) => {
161163
if (index === 4) {
162-
return { x: 0, y: index * 100, width: 100, height: 25 } as Layout;
164+
return { x: 0, y: index * 100, width: 100, height: 25 } as RVLayout;
163165
}
164-
return { x: 0, y: index * 100, height: 100, width: 300 } as Layout;
166+
return { x: 0, y: index * 100, height: 100, width: 300 } as RVLayout;
165167
};
166168
const viewabilityHelper = new ViewabilityHelper(
167169
{ viewAreaCoveragePercentThreshold: 25 },
@@ -260,8 +262,8 @@ describe("ViewabilityHelper", () => {
260262
viewabilityHelper: ViewabilityHelper;
261263
horizontal?: boolean;
262264
scrollOffset?: number;
263-
listSize?: Dimension;
264-
getLayout?: (index: number) => Layout | undefined;
265+
listSize?: RVDimension;
266+
getLayout?: (index: number) => RVLayout | undefined;
265267
runAllTimers?: boolean;
266268
}) => {
267269
viewabilityHelper.updateViewableItems(
@@ -270,7 +272,7 @@ describe("ViewabilityHelper", () => {
270272
listSize ?? { height: 300, width: 300 },
271273
getLayout ??
272274
((index) => {
273-
return { x: 0, y: index * 100, height: 100, width: 300 } as Layout;
275+
return { x: 0, y: index * 100, height: 100, width: 300 } as RVLayout;
274276
})
275277
);
276278
if (runAllTimers ?? true) {

‎src/native/config/PlatformHelper.android.ts

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,7 @@
1-
import { BaseItemAnimator } from "recyclerlistview";
2-
31
const PlatformConfig = {
42
defaultDrawDistance: 250,
53
supportsOffsetCorrection: true,
64
trackAverageRenderTimeForOffsetProjection: true,
7-
// Using rotate instead of scaleY on Android to avoid performance issues. Issue: https://github.com/Shopify/flash-list/issues/751
8-
invertedTransformStyle: { transform: [{ rotate: "180deg" }] },
9-
invertedTransformStyleHorizontal: { transform: [{ rotate: "180deg" }] },
10-
};
11-
const getCellContainerPlatformStyles = (
12-
inverted: boolean,
13-
parentProps: { x: number; y: number; isHorizontal?: boolean }
14-
): { transform: string; WebkitTransform: string } | undefined => {
15-
return undefined;
16-
};
17-
18-
const getItemAnimator = (): BaseItemAnimator | undefined => {
19-
return undefined;
205
};
216

22-
const getFooterContainer = (): React.ComponentClass | undefined => {
23-
return undefined;
24-
};
25-
26-
export {
27-
PlatformConfig,
28-
getCellContainerPlatformStyles,
29-
getItemAnimator,
30-
getFooterContainer,
31-
};
7+
export { PlatformConfig };

‎src/native/config/PlatformHelper.ios.ts

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,7 @@
1-
import { BaseItemAnimator } from "recyclerlistview";
2-
31
const PlatformConfig = {
42
defaultDrawDistance: 250,
53
supportsOffsetCorrection: true,
64
trackAverageRenderTimeForOffsetProjection: false,
7-
invertedTransformStyle: { transform: [{ scaleY: -1 }] },
8-
invertedTransformStyleHorizontal: { transform: [{ scaleX: -1 }] },
9-
};
10-
const getCellContainerPlatformStyles = (
11-
inverted: boolean,
12-
parentProps: { x: number; y: number; isHorizontal?: boolean }
13-
): { transform: string; WebkitTransform: string } | undefined => {
14-
return undefined;
15-
};
16-
17-
const getItemAnimator = (): BaseItemAnimator | undefined => {
18-
return undefined;
195
};
206

21-
const getFooterContainer = (): React.ComponentClass | undefined => {
22-
return undefined;
23-
};
24-
25-
export {
26-
PlatformConfig,
27-
getCellContainerPlatformStyles,
28-
getItemAnimator,
29-
getFooterContainer,
30-
};
7+
export { PlatformConfig };

‎src/native/config/PlatformHelper.ts

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,7 @@
1-
import { BaseItemAnimator } from "recyclerlistview";
2-
import { DefaultJSItemAnimator } from "recyclerlistview/dist/reactnative/platform/reactnative/itemanimators/defaultjsanimator/DefaultJSItemAnimator";
3-
41
const PlatformConfig = {
52
defaultDrawDistance: 250,
63
supportsOffsetCorrection: false,
74
trackAverageRenderTimeForOffsetProjection: false,
8-
invertedTransformStyle: { transform: [{ scaleY: -1 }] },
9-
invertedTransformStyleHorizontal: { transform: [{ scaleX: -1 }] },
10-
};
11-
const getCellContainerPlatformStyles = (
12-
inverted: boolean,
13-
parentProps: { x: number; y: number; isHorizontal?: boolean }
14-
): { transform: string; WebkitTransform: string } | undefined => {
15-
return undefined;
16-
};
17-
18-
const getItemAnimator = (): BaseItemAnimator | undefined => {
19-
return new DefaultJSItemAnimator();
205
};
216

22-
const getFooterContainer = (): React.ComponentClass | undefined => {
23-
return undefined;
24-
};
25-
26-
export {
27-
PlatformConfig,
28-
getCellContainerPlatformStyles,
29-
getItemAnimator,
30-
getFooterContainer,
31-
};
7+
export { PlatformConfig };

‎src/native/config/PlatformHelper.web.ts

Lines changed: 1 addition & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,7 @@
1-
import React from "react";
2-
import { View } from "react-native";
3-
import { BaseItemAnimator } from "recyclerlistview";
4-
import { DefaultJSItemAnimator } from "recyclerlistview/dist/reactnative/platform/reactnative/itemanimators/defaultjsanimator/DefaultJSItemAnimator";
5-
61
const PlatformConfig = {
72
defaultDrawDistance: 500,
83
supportsOffsetCorrection: false,
94
trackAverageRenderTimeForOffsetProjection: false,
10-
invertedTransformStyle: { transform: [{ scaleY: -1 }] },
11-
invertedTransformStyleHorizontal: { transform: [{ scaleX: -1 }] },
12-
};
13-
const getCellContainerPlatformStyles = (
14-
inverted: boolean,
15-
parentProps: { x: number; y: number; isHorizontal?: boolean }
16-
): { transform: string; WebkitTransform: string } | undefined => {
17-
const transformValue = `translate(${parentProps.x}px,${parentProps.y}px)${
18-
inverted ? ` ${parentProps.isHorizontal ? `scaleX` : `scaleY`}(-1)` : ``
19-
}`;
20-
return { transform: transformValue, WebkitTransform: transformValue };
21-
};
22-
23-
const getItemAnimator = (): BaseItemAnimator | undefined => {
24-
return new DefaultJSItemAnimator();
255
};
266

27-
const getFooterContainer = (): React.ComponentClass | undefined => {
28-
return View;
29-
};
30-
31-
export {
32-
PlatformConfig,
33-
getCellContainerPlatformStyles,
34-
getItemAnimator,
35-
getFooterContainer,
36-
};
7+
export { PlatformConfig };

‎yarn.lock

Lines changed: 7 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -5324,7 +5324,7 @@ locate-path@^6.0.0:
53245324
dependencies:
53255325
p-locate "^5.0.0"
53265326

5327-
lodash.debounce@4.0.8, lodash.debounce@^4.0.8:
5327+
lodash.debounce@^4.0.8:
53285328
version "4.0.8"
53295329
resolved "https://registry.yarnpkg.com/lodash.debounce/-/lodash.debounce-4.0.8.tgz#82d79bff30a67c4005ffd5e2515300ad9ca4d7af"
53305330
integrity sha1-gteb/zCmfEAF/9XiUVMArZyk168=
@@ -6236,7 +6236,7 @@ prompts@^2.0.1:
62366236
kleur "^3.0.3"
62376237
sisteransi "^1.0.5"
62386238

6239-
prop-types@15.8.1, prop-types@^15.8.1:
6239+
prop-types@^15.8.1:
62406240
version "15.8.1"
62416241
resolved "https://registry.yarnpkg.com/prop-types/-/prop-types-15.8.1.tgz#67d87bf1a694f48435cf332c24af10214a3140b5"
62426242
integrity sha512-oj87CgZICdulUohogVAR7AjlC0327U4el4L6eAvOqCeudMDVU0NThNaV+b9Df4dXgSP1gXMTnPdhfe/2qDH5cg==
@@ -6401,15 +6401,6 @@ recast@^0.21.0:
64016401
source-map "~0.6.1"
64026402
tslib "^2.0.1"
64036403

6404-
[email protected]:
6405-
version "4.2.3"
6406-
resolved "https://registry.yarnpkg.com/recyclerlistview/-/recyclerlistview-4.2.3.tgz#14032e7ad2f24396e24d5b3060c6ba76b567f000"
6407-
integrity sha512-STR/wj/FyT8EMsBzzhZ1l2goYirMkIgfV3gYEPxI3Kf3lOnu6f7Dryhyw7/IkQrgX5xtTcDrZMqytvteH9rL3g==
6408-
dependencies:
6409-
lodash.debounce "4.0.8"
6410-
prop-types "15.8.1"
6411-
ts-object-utils "0.0.5"
6412-
64136404
regenerate-unicode-properties@^10.0.1:
64146405
version "10.0.1"
64156406
resolved "https://registry.yarnpkg.com/regenerate-unicode-properties/-/regenerate-unicode-properties-10.0.1.tgz#7f442732aa7934a3740c779bb9b3340dccc1fb56"
@@ -7064,11 +7055,6 @@ ts-node@^9:
70647055
source-map-support "^0.5.17"
70657056
yn "3.1.1"
70667057

7067-
[email protected]:
7068-
version "0.0.5"
7069-
resolved "https://registry.yarnpkg.com/ts-object-utils/-/ts-object-utils-0.0.5.tgz#95361cdecd7e52167cfc5e634c76345e90a26077"
7070-
integrity sha1-lTYc3s1+UhZ8/F5jTHY0XpCiYHc=
7071-
70727058
tsconfig-paths@^3.12.0:
70737059
version "3.14.0"
70747060
resolved "https://registry.yarnpkg.com/tsconfig-paths/-/tsconfig-paths-3.14.0.tgz#4fcc48f9ccea8826c41b9ca093479de7f5018976"
@@ -7079,16 +7065,16 @@ tsconfig-paths@^3.12.0:
70797065
minimist "^1.2.0"
70807066
strip-bom "^3.0.0"
70817067

7082-
[email protected], tslib@^2, tslib@^2.0.1, tslib@^2.0.3:
7083-
version "2.8.1"
7084-
resolved "https://registry.yarnpkg.com/tslib/-/tslib-2.8.1.tgz#612efe4ed235d567e8aba5f2a5fab70280ade83f"
7085-
integrity sha512-oJFu94HQb+KVduSUQL7wnpmqnfmLsOA/nAh6b6EH0wCEoK0/mPeXU6c3wKDV83MkOuHPRHtSXKKU99IBazS/2w==
7086-
70877068
tslib@^1.8.1:
70887069
version "1.14.1"
70897070
resolved "https://registry.yarnpkg.com/tslib/-/tslib-1.14.1.tgz#cf2d38bdc34a134bcaf1091c41f6619e2f672d00"
70907071
integrity sha512-Xni35NKzjgMrwevysHTCArtLDpPvye8zV/0E4EyYn43P7/7qvQwPh9BGkHewbMulVntbigmcT7rdX3BNo9wRJg==
70917072

7073+
tslib@^2, tslib@^2.0.1, tslib@^2.0.3:
7074+
version "2.8.1"
7075+
resolved "https://registry.yarnpkg.com/tslib/-/tslib-2.8.1.tgz#612efe4ed235d567e8aba5f2a5fab70280ade83f"
7076+
integrity sha512-oJFu94HQb+KVduSUQL7wnpmqnfmLsOA/nAh6b6EH0wCEoK0/mPeXU6c3wKDV83MkOuHPRHtSXKKU99IBazS/2w==
7077+
70927078
tslib@~2.0.1:
70937079
version "2.0.3"
70947080
resolved "https://registry.yarnpkg.com/tslib/-/tslib-2.0.3.tgz#8e0741ac45fc0c226e58a17bfc3e64b9bc6ca61c"

0 commit comments

Comments
 (0)