[action needed] support RN 0.77

[vonovak]

Hello,
because of facebook/react-native#46809 there are changes that need to be done, similar to AppAndFlow/react-native-safe-area-context#566. This is a heads up for the maintainers.

Current behavior

build with old architecture on RN 0.77 fails with

e: file:@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/AutoLayoutViewManager.kt:16:74 Type argument is not within its bounds: should be subtype of 'it(BaseViewManagerInterface & com.facebook.react.viewmanagers.AutoLayoutViewManagerInterface<com.shopify.reactnative.flash_list.AutoLayoutView!>)!'.
e: file:@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/AutoLayoutViewManager.kt:17:39 Argument type mismatch: actual type is 'com.shopify.reactnative.flash_list.AutoLayoutViewManager', but 'U!' was expected.
e: file:@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/CellContainerManager.kt:13:76 Type argument is not within its bounds: should be subtype of 'it(BaseViewManagerInterface & com.facebook.react.viewmanagers.CellContainerManagerInterface<com.shopify.reactnative.flash_list.CellContainerImpl!>)!'.
e: file:@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/CellContainerManager.kt:14:40 Argument type mismatch: actual type is 'com.shopify.reactnative.flash_list.CellContainerManager', but 'U!' was expected.

Expected behavior

build should pass

To Reproduce

upgrade to latest RN 0.77 and build an app with flash list dep, with old arch

Platform:

• iOS
• Android

Environment

x.y.z

[tomekzaw]

Here's a patch that adds support for RN 0.77: @shopify-flash-list-npm-1.7.2-2a363895ca.patch

[RohovDmytro]

The patch works perfectly and today React Native 0.77.0 was released. :)

[ChronoByteCosmonaut]

Here's a patch that adds support for RN 0.77: @shopify-flash-list-npm-1.7.2-2a363895ca.patch

At least someone cares 🙏

[efstathiosntonas]

@tomekzaw thanks for the patch, I guess this is not backwards compatible for older versions of rn, correct?

[tomekzaw]

@efstathiosntonas To be honest I haven't checked that, I would safely assume that it's not.

[vonovak]

Hello, I believe that it is backward compatible (question is, down to which version?). RN SVG and others had to do the same change and they didn't do a major bump.

[ssavran]

Here's a patch that adds support for RN 0.77: @shopify-flash-list-npm-1.7.2-2a363895ca.patch

Steps I did so far:
1 - downloaded your patch
2 - put it under ./node_modules/@shopify/flash-list
3 - called git apply in the same folder @shopify-flash-list-npm-1.7.2-2a363895ca.patch
4 - got back into the android folder of my own project and called ./gradlew clean assembleDebug and still get an error:

Task :shopify_flash-list:compileDebugKotlin FAILED
e: file:///Users/sercansametsavran/Documents/Viveel/ViveelProject/Viveelupdate/Viveel/node_modules/@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/AutoLayoutViewManager.kt:16:74 Type argument is not within its bounds: should be subtype of 'it(BaseViewManagerInterface & com.facebook.react.viewmanagers.AutoLayoutViewManagerInterface<com.shopify.reactnative.flash_list.AutoLayoutView!>)!'.
e: file:///Users/sercansametsavran/Documents/Viveel/ViveelProject/Viveelupdate/Viveel/node_modules/@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/AutoLayoutViewManager.kt:17:39 Argument type mismatch: actual type is 'com.shopify.reactnative.flash_list.AutoLayoutViewManager', but 'U!' was expected.
e: file:///Users/sercansametsavran/Documents/Viveel/ViveelProject/Viveelupdate/Viveel/node_modules/@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/CellContainerManager.kt:13:76 Type argument is not within its bounds: should be subtype of 'it(BaseViewManagerInterface & com.facebook.react.viewmanagers.CellContainerManagerInterface<com.shopify.reactnative.flash_list.CellContainerImpl!>)!'.
e: file:///Users/sercansametsavran/Documents/Viveel/ViveelProject/Viveelupdate/Viveel/node_modules/@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/CellContainerManager.kt:14:40 Argument type mismatch: actual type is 'com.shopify.reactnative.flash_list.CellContainerManager', but 'U!' was expected.

Any ideas, what might went wrong in my case?

EDIT: I think your patch was just for the java classes and in my case the kotlin classes have the errors...

[MaxTheTurtle0]

Here's a patch that adds support for RN 0.77: @shopify-flash-list-npm-1.7.2-2a363895ca.patch

Steps I did so far: 1 - downloaded your patch 2 - put it under ./node_modules/@shopify/flash-list 3 - called git apply in the same folder @shopify-flash-list-npm-1.7.2-2a363895ca.patch 4 - got back into the android folder of my own project and called ./gradlew clean assembleDebug and still get an error:

Task :shopify_flash-list:compileDebugKotlin FAILED
e: file:///Users/sercansametsavran/Documents/Viveel/ViveelProject/Viveelupdate/Viveel/node_modules/@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/AutoLayoutViewManager.kt:16:74 Type argument is not within its bounds: should be subtype of 'it(BaseViewManagerInterface & com.facebook.react.viewmanagers.AutoLayoutViewManagerInterface<com.shopify.reactnative.flash_list.AutoLayoutView!>)!'.
e: file:///Users/sercansametsavran/Documents/Viveel/ViveelProject/Viveelupdate/Viveel/node_modules/@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/AutoLayoutViewManager.kt:17:39 Argument type mismatch: actual type is 'com.shopify.reactnative.flash_list.AutoLayoutViewManager', but 'U!' was expected.
e: file:///Users/sercansametsavran/Documents/Viveel/ViveelProject/Viveelupdate/Viveel/node_modules/@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/CellContainerManager.kt:13:76 Type argument is not within its bounds: should be subtype of 'it(BaseViewManagerInterface & com.facebook.react.viewmanagers.CellContainerManagerInterface<com.shopify.reactnative.flash_list.CellContainerImpl!>)!'.
e: file:///Users/sercansametsavran/Documents/Viveel/ViveelProject/Viveelupdate/Viveel/node_modules/@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/CellContainerManager.kt:14:40 Argument type mismatch: actual type is 'com.shopify.reactnative.flash_list.CellContainerManager', but 'U!' was expected.

Any ideas, what might went wrong in my case?

EDIT: I think your patch was just for the java classes and in my case the kotlin classes have the errors...

I am getting the same error