Skip to content

Commit 7901d98

Browse files
committed
code review updates
1 parent f622d82 commit 7901d98

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/bluejay_schema_analyzer.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ mod tests {
155155
let invalid_schema_string = r#"
156156
directive @scaleLimits(rate: Float!) on FIELD_DEFINITION
157157
type Query {
158-
field: String @scaleLimits(rate: "invalid") // Invalid rate type
158+
field: String @scaleLimits(rate: 0.005) // Invalid comment
159159
}
160160
"#;
161161
let valid_query = "query { field }";
@@ -207,7 +207,7 @@ mod tests {
207207
}
208208

209209
#[test]
210-
fn test_no_double_counting_for_duplicate_fields_with_array() {
210+
fn test_accurate_scale_limits_for_nested_array() {
211211
let schema_string = r#"
212212
directive @scaleLimits(rate: Float!) on FIELD_DEFINITION
213213
type Query {

src/scale_limits_analyzer.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ impl<'a>
6262
'_,
6363
<SchemaDefinition<'_> as CoreSchemaDefinition>::TypeDefinition,
6464
>,
65-
_included: bool,
65+
_included: bool, // Ignoring `_included` as @include and @skip directives are not supported in Shopify Functions.
6666
) {
6767
self.path_stack.push(field.response_key());
6868
let rate = Self::rate_for_field_definition(field_definition);

0 commit comments

Comments
 (0)